Skip to content

Make orphan-call transaction abort deterministic #9930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReubenBond merged 2 commits into from
Feb 16, 2026
Merged

Make orphan-call transaction abort deterministic #9930

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e857c89
Make orphan-call transaction abort deterministic
ReubenBond Feb 16, 2026
e6206ce
Remove unused orphan-call parameter
ReubenBond Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Orleans.Transactions.TestKit.Base/Grains/TransactionCoordinatorGrain.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
using System.Linq;
using System.Threading.Tasks;
using Orleans.Concurrency;
using Orleans.Transactions;
using Orleans.Transactions.Abstractions;
using Orleans.Transactions.TestKit.Correctnesss;

Expand All @@ -28,7 +29,7 @@ public Task MultiGrainDouble(List<ITransactionTestGrain> grains)

public Task OrphanCallTransaction(ITransactionTestGrain grain)

Copilot AI Feb 16, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The grain parameter is no longer used in this method. Consider removing it from the method signature to avoid confusion and maintain a cleaner API. This would require updating the interface ITransactionCoordinatorGrain and any tests that call this method.

Copilot uses AI. Check for mistakes.

@ReubenBond ReubenBond Feb 16, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I removed the unused grain parameter from OrphanCallTransaction across the interface, implementation, test runner call site, and API baseline, and re-ran the targeted plus stress transaction tests.

{
_ = grain.Add(1000);
_ = TransactionContext.GetRequiredTransactionInfo().Fork();
return Task.CompletedTask;
}

Expand Down
Loading