Skip to content

Make orphan-call transaction abort deterministic #9930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReubenBond merged 2 commits into from
Feb 16, 2026
Merged

Make orphan-call transaction abort deterministic #9930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e857c89
Make orphan-call transaction abort deterministic
ReubenBond Feb 16, 2026
e6206ce
Remove unused orphan-call parameter
ReubenBond Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Orleans.Transactions.TestKit.Base/Grains/ITransactionCoordinatorGrain.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public interface ITransactionCoordinatorGrain : IGrainWithGuidKey
Task MultiGrainDoubleByWRWR(List<ITransactionTestGrain> grains, int numberToAdd);

[Transaction(TransactionOption.Create)]
Task OrphanCallTransaction(ITransactionTestGrain grain);
Task OrphanCallTransaction();

[Transaction(TransactionOption.Create)]
Task AddAndThrow(ITransactionTestGrain grain, int numberToAdd);
Expand Down
5 changes: 3 additions & 2 deletions src/Orleans.Transactions.TestKit.Base/Grains/TransactionCoordinatorGrain.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
using System.Linq;
using System.Threading.Tasks;
using Orleans.Concurrency;
using Orleans.Transactions;
using Orleans.Transactions.Abstractions;
using Orleans.Transactions.TestKit.Correctnesss;

Expand All @@ -26,9 +27,9 @@ public Task MultiGrainDouble(List<ITransactionTestGrain> grains)
return Task.WhenAll(grains.Select(Double));
}

public Task OrphanCallTransaction(ITransactionTestGrain grain)
public Task OrphanCallTransaction()
{
_ = grain.Add(1000);
_ = TransactionContext.GetRequiredTransactionInfo().Fork();
return Task.CompletedTask;
}

Expand Down
2 changes: 1 addition & 1 deletion src/Orleans.Transactions.TestKit.Base/TestRunners/GrainFaultTransactionTestRunner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ public virtual async Task AbortTransactionOnOrphanCalls(string grainStates)
ITransactionCoordinatorGrain coordinator = this.grainFactory.GetGrain<ITransactionCoordinatorGrain>(Guid.NewGuid());

await grain.Set(expected);
Func<Task> task = () => coordinator.OrphanCallTransaction(grain);
Func<Task> task = () => coordinator.OrphanCallTransaction();
await task.Should().ThrowAsync<OrleansOrphanCallException>();

//await Task.Delay(20000); // give time for GC
Expand Down
4 changes: 2 additions & 2 deletions src/api/Orleans.Transactions.TestKit.Base/Orleans.Transactions.TestKit.Base.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ public partial interface ITransactionCoordinatorGrain : IGrainWithGuidKey, IGrai
[Transaction(TransactionOption.Create)]
System.Threading.Tasks.Task MultiGrainSetBit(System.Collections.Generic.List<Correctnesss.ITransactionalBitArrayGrain> grains, int bitIndex);
[Transaction(TransactionOption.Create)]
System.Threading.Tasks.Task OrphanCallTransaction(ITransactionTestGrain grain);
System.Threading.Tasks.Task OrphanCallTransaction();
[Transaction(TransactionOption.Create)]
[Concurrency.ReadOnly]
System.Threading.Tasks.Task UpdateViolated(ITransactionTestGrain grains, int numberToAdd);
Expand Down Expand Up @@ -719,7 +719,7 @@ public partial class TransactionCoordinatorGrain : Grain, ITransactionCoordinato

public System.Threading.Tasks.Task MultiGrainSetBit(System.Collections.Generic.List<Correctnesss.ITransactionalBitArrayGrain> grains, int bitIndex) { throw null; }

public System.Threading.Tasks.Task OrphanCallTransaction(ITransactionTestGrain grain) { throw null; }
public System.Threading.Tasks.Task OrphanCallTransaction() { throw null; }

public System.Threading.Tasks.Task UpdateViolated(ITransactionTestGrain grain, int numberToAdd) { throw null; }
}
Expand Down
Loading