Skip to content

Fix flaky Sched_Task_ClosureWorkItem_Wait scheduler test #9916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReubenBond merged 1 commit into from
Feb 15, 2026
Merged

Fix flaky Sched_Task_ClosureWorkItem_Wait scheduler test #9916

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions test/NonSilo.Tests/SchedulerTests/OrleansTaskSchedulerBasicTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ public async Task Sched_Task_TplFifoTest()
public async Task Sched_Task_ClosureWorkItem_Wait()
{
const int NumTasks = 10;
var workItemCompletionTimeout = TimeSpan.FromSeconds(10);

var flags = new ManualResetEvent[NumTasks];
for (var i = 0; i < NumTasks; i++)
Expand All @@ -177,27 +178,22 @@ public async Task Sched_Task_ClosureWorkItem_Wait()
tasks[i] = new Task(() => { _output.WriteLine("Inside Task-" + taskNum); flags[taskNum].WaitOne(); });
}

var workItems = new Action[NumTasks];
var workItems = new Task[NumTasks];
for (var i = 0; i < NumTasks; i++)
{
var taskNum = i; // Capture
workItems[i] = () =>
workItems[i] = _rootContext.QueueAction(taskIndex =>
Comment thread
ReubenBond marked this conversation as resolved.
{
_output.WriteLine("Inside ClosureWorkItem-" + taskNum);
tasks[taskNum].Start(TaskScheduler.Default);
_output.WriteLine("Inside ClosureWorkItem-" + taskIndex);
tasks[taskIndex].Start(TaskScheduler.Default);
#pragma warning disable xUnit1031 // Do not use blocking task operations in test method
var ok = tasks[taskNum].Wait(TimeSpan.FromMilliseconds(NumTasks * 100));
tasks[taskIndex].Wait();
#pragma warning restore xUnit1031 // Do not use blocking task operations in test method
Assert.True(ok, "Wait completed successfully inside ClosureWorkItem-" + taskNum);
};
}, taskNum);
}

foreach (var workItem in workItems) _rootContext.Scheduler.QueueAction(workItem);
foreach (var flag in flags) flag.Set();
for (var i = 0; i < tasks.Length; i++)
{
await tasks[i].WaitAsync(TimeSpan.FromMilliseconds(NumTasks * 150));
}
await Task.WhenAll(workItems).WaitAsync(workItemCompletionTimeout);


for (var i = 0; i < tasks.Length; i++)
Expand Down
Loading