Fix flaky Sched_Task_ClosureWorkItem_Wait scheduler test#9916
Merged
ReubenBond merged 1 commit intoFeb 15, 2026
Merged
Conversation
Queue closure work items via QueueAction to await scheduler turn completion deterministically and remove race-prone short waits. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a flaky scheduler test by replacing short per-task timeouts with a single collective timeout for all work items. The test previously raced scheduler turn completion against individual task timeouts, causing intermittent failures.
Changes:
- Modified
Sched_Task_ClosureWorkItem_Waitto useQueueAction<TState>which returns Task objects for tracking work item completion - Replaced individual task waits with timeouts with
Task.WhenAll().WaitAsync()for collective completion tracking - Removed the explicit loop that queued work items separately (now queued inline during creation)
rkargMsft
pushed a commit
to rkargMsft/orleans
that referenced
this pull request
Feb 27, 2026
Fix flaky Sched_Task_ClosureWorkItem_Wait Queue closure work items via QueueAction to await scheduler turn completion deterministically and remove race-prone short waits. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change stabilizes
UnitTests.SchedulerTests.OrleansTaskSchedulerBasicTests.Sched_Task_ClosureWorkItem_Wait._rootContext.QueueAction(...)so each closure has an awaitable completion task.Task.WhenAll(workItems).WaitAsync(TimeSpan.FromSeconds(10)).Validation
dotnet test test\NonSilo.Tests\NonSilo.Tests.csproj --filter "FullyQualifiedName=UnitTests.SchedulerTests.OrleansTaskSchedulerBasicTests.Sched_Task_ClosureWorkItem_Wait" -c Release(repeated 50x with--no-buildafter first run)dotnet test test\NonSilo.Tests\NonSilo.Tests.csproj --filter "FullyQualifiedName~UnitTests.SchedulerTests.OrleansTaskSchedulerBasicTests" -c Release --no-build