Pass PlacementTarget into Filter method #9482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for Request Context to be used for placement decisions. In the future we may want to allow for caching of filtering decisions (between membership updates and potentially some other criteria that we get from the implementation of a filter), but that would need to be opt-in from the filter implementation and the filter would need to accept that it's results may be cached. This would still be possible after this change as it would rely on the filter implementation's intent to be cached and not strictly enforced (this is a similar pattern to `[Immutable]`)
This was referenced May 7, 2025
ReubenBond
approved these changes
May 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for Request Context to be used for placement decisions.
In the future we may want to allow for caching of filtering decisions (between membership updates and potentially some other criteria that we get from the implementation of a filter), but that would need to be opt-in from the filter implementation and the filter would need to accept that it's results may be cached. This would still be possible after this change as it would rely on the filter implementation's intent to be cached and not strictly enforced (this is a similar pattern to
[Immutable])Microsoft Reviewers: Open in CodeFlow