Change the priority order of lazyloading #9744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuliiaKovalova
approved these changes
Feb 15, 2024
|
It looks good, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9736
Context
During the improvement of item evalution #9047, the MsBuildSkipEagerWildCardEvaluationRegexes variable was skipped for some cases: When the exclude was defined with MsBuildSkipEagerWildCardEvaluationRegexes. It resulted the listing of the non needed file (according to lazyload)
Changes Made
Changed the priority of the lazyLoading regex. Firstly it will compare it and then will check if it is nowildcard file with no exclusions
Testing
Added failed scenario to existing test: LazyWildcardExpansionDoesNotEvaluateWildCardsIfNotReferenced.
Notes