Skip to content

Stop loading Microsoft.DevDiv files as read-only #7007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Stop loading Microsoft.DevDiv files as read-only #7007

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 9 additions & 16 deletions src/Build/ElementLocation/XmlDocumentWithLocation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,24 +352,17 @@ private void DetermineWhetherToLoadReadOnly(string fullPath)
// Only files from Microsoft
if (Path.GetFileName(fullPath).StartsWith("Microsoft.", StringComparison.OrdinalIgnoreCase))
{
// If we are loading devdiv targets, we're in razzle
if (Path.GetFileName(fullPath).StartsWith("Microsoft.DevDiv", StringComparison.OrdinalIgnoreCase))
{
_loadAsReadOnly = true;
}
else // Else, only load if they're in program files or windows directories
{
ErrorUtilities.VerifyThrow(Path.IsPathRooted(fullPath), "should be full path");
string directory = Path.GetDirectoryName(fullPath);
// Load read-only if they're in program files or windows directories
ErrorUtilities.VerifyThrow(Path.IsPathRooted(fullPath), "should be full path");
string directory = Path.GetDirectoryName(fullPath);

string windowsFolder = Environment.GetFolderPath(Environment.SpecialFolder.Windows);
string windowsFolder = Environment.GetFolderPath(Environment.SpecialFolder.Windows);

if ((!String.IsNullOrEmpty(windowsFolder) && directory.StartsWith(windowsFolder, StringComparison.OrdinalIgnoreCase)) ||
(!String.IsNullOrEmpty(FrameworkLocationHelper.programFiles32) && directory.StartsWith(FrameworkLocationHelper.programFiles32, StringComparison.OrdinalIgnoreCase)) ||
(!String.IsNullOrEmpty(FrameworkLocationHelper.programFiles64) && directory.StartsWith(FrameworkLocationHelper.programFiles64, StringComparison.OrdinalIgnoreCase)))
{
_loadAsReadOnly = true;
}
if ((!String.IsNullOrEmpty(windowsFolder) && directory.StartsWith(windowsFolder, StringComparison.OrdinalIgnoreCase)) ||
(!String.IsNullOrEmpty(FrameworkLocationHelper.programFiles32) && directory.StartsWith(FrameworkLocationHelper.programFiles32, StringComparison.OrdinalIgnoreCase)) ||
(!String.IsNullOrEmpty(FrameworkLocationHelper.programFiles64) && directory.StartsWith(FrameworkLocationHelper.programFiles64, StringComparison.OrdinalIgnoreCase)))
{
_loadAsReadOnly = true;
}
}
}
Expand Down