Stop loading Microsoft.DevDiv files as read-only #7007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a change in the VS project editing experience, see the email thread about InvalidOperationException. Unblocking an internal scenario and cleaning up the code? That's a win-win! 😄 |
rainersigwald
approved these changes
Nov 1, 2021
Forgind
added
the
merge-when-branch-open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
MSBuild currently loads all files whose name starts with
Microsoft.DevDivas read-only. It is breaking scenarios where such files are legitimately written to. It is unfortunate to use hard-codes names in general.Changes Made
Removed the special handling.
Testing
Ideally would verify that the Visual Studio repo builds fine with this change but it looks like too much hassle for such a safe change (famous last words).