Remove pinned .NET Framework ref assembly package: let SDK provide it #6986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainersigwald
approved these changes
Oct 22, 2021
There was a problem hiding this comment.
LGTM if it works. @KirillOsenkov if you can't test let me know and we'll get a clean VM set up.
KirillOsenkov
approved these changes
Oct 24, 2021
There was a problem hiding this comment.
OK, yes, confirmed the main branch fails to build, but this PR builds successfully.
Thanks @dagood for the quick turnaround!
|
Glad to help, and good to hear! I don't have merge permissions here, so please feel free to go ahead when the time is right. 🙂 |
rainersigwald
added
the
merge-when-branch-open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6935
Context
See #6966 (comment)
Changes Made
Remove the package reference on
Microsoft.NETFramework.ReferenceAssemblies/1.0.0, which should let the SDK provide aMicrosoft.NETFramework.ReferenceAssemblies/1.0.2(or higher) reference.Testing
Built on Fedora 33 Linux with
./build.sh.@KirillOsenkov Can you give this a shot?