-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Remove jnm2.ReferenceAssemblies.net35 to remove it as a prebuilt dependency for source-build #6966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This prebuilt package filled a gap in the official 1.0 version of the .NET Framework reference assembly packages. The gap has been fixed in later versions of the official packages. Removal fixes a prebuilt dependency by letting the repo use the official version of the packages, which are produced by SBRP.
6aff19b
to
52573bb
Compare
Do you want this for 17.0/6.0GA, or just "the next release" 17.1/6.0.2xx? |
Ah, yeah, 6.0 GA, so we can remove the patch in dotnet/installer for servicing releases (and get more accurate prebuilt detection in this repo itself). Same for #6967. Sounds like the What porting strategy does this repo use--cherry-pick to release branch after/simultaneously with |
PR to release branch which gets merged back to main in MSBuild, please. I have no objection to these but we may have to have a discussion on our side about getting them in, since we're in QB mode for VS. I suspect we can roll these plus #6902 together as "required infra changes for GA"--@marcpopMSFT, do you have a preference? |
I'm checking with the source-build team on the priority. I'm just temporarily helping out with source-build right now and I don't have full context on these patch application PRs. It doesn't seem necessary to me to get it through QB (we'll just have a patch in dotnet/installer for 6.0.0 that hopefully can make it into servicing for 6.0.1) but I don't want to say that definitively. |
This is ok to defer until servicing. @MichaelSimons confirmed that we hit QB mode with vstest, too, and also deferred there. |
Sounds like 17.1 then |
I just noticed I'd misread this as "when it gets merged" and I was waiting for that. 😅 I'll rebase the PRs on |
No need! |
Hmm @dagood I'm building on a machine without .NET 3.5 SP1 ref assemblies installed and I'm getting this? Have we tested building MSBuild with this on a clean machine? |
Hmm, still 1.0.0 here: Line 48 in 808b2ae
|
Not on a Windows machine, no. It works in the context of a clean source-build. |
Ah, yep, I think that would downgrade from whatever the SDK's trying to add automatically (probably 1.0.2) down to 1.0.0. I think that itemgroup just needs to be removed, like it is for source-build in the condition: Lines 47 to 49 in 808b2ae
I think it would show up in a non-source-build build on Linux, too. I can try a quick removal. |
This prebuilt package filled a gap in the official 1.0 version of the .NET Framework reference assembly packages. The gap has been fixed in later versions of the official packages. Removal fixes a prebuilt dependency by letting the repo use the official version of the packages, which are produced by SBRP.
I removed
<BypassFrameworkInstallChecks>true</BypassFrameworkInstallChecks>
because the comment essentially says that it shouldn't be necessary anymore and it sounds like a good idea to enable checks when I can, but I'm not actually familiar with what the checks do. 😄Fixes #6935