Skip to content

remove dead code #13125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimaTian merged 3 commits into from
Jan 28, 2026
Merged

remove dead code #13125

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7677a89
remove dead code
SimaTian Jan 27, 2026
81d2951
remove the if alltogether
SimaTian Jan 27, 2026
8512a79
Update ValidateMSBuildPackageDependencyVersions.cs
SimaTian Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 11 additions & 28 deletions src/MSBuild/ValidateMSBuildPackageDependencyVersions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,38 +87,21 @@ public override bool Execute()
string assemblyVersion = AssemblyName.GetAssemblyName(path).Version.ToString();
if (!version.Equals(assemblyVersion))
{
// Ensure that the binding redirect is to the GAC version, but
// we still ship the version we explicitly reference to let
// API consumers bind to it at runtime.
// See https://github.com/dotnet/msbuild/issues/6976.
Comment thread
SimaTian marked this conversation as resolved.
if (String.Equals(name, "System.ValueTuple", StringComparison.OrdinalIgnoreCase) &&
String.Equals(version, "4.0.0.0") && String.Equals(assemblyVersion, "4.0.3.0"))
{
// foundSystemValueTuple = true;
}
else
{
Log.LogError(
subcategory: null,
errorCode: null,
helpKeyword: null,
file: appConfigPath,
lineNumber: bindingRedirectLineNumber,
columnNumber: 0,
endLineNumber: 0,
endColumnNumber: 0,
message: $"Binding redirect for '{name}' redirects to a different version ({version}) than MSBuild ships ({assemblyVersion}).");
}
Log.LogError(
subcategory: null,
errorCode: null,
helpKeyword: null,
file: appConfigPath,
lineNumber: bindingRedirectLineNumber,
columnNumber: 0,
endLineNumber: 0,
endColumnNumber: 0,
message: $"Binding redirect for '{name}' redirects to a different version ({version}) than MSBuild ships ({assemblyVersion}).");

}
}
}
}

// if (!foundSystemValueTuple)
// {
// Log.LogError("Binding redirect for 'System.ValueTuple' missing.");
// }

return !Log.HasLoggedErrors;
}
}
Expand Down