Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to clean up dead code in ValidateMSBuildPackageDependencyVersions related to special handling of System.ValueTuple binding redirects, as requested in issue #13082.
Changes:
- Removed a commented-out
foundSystemValueTupletracking block and its associated final error log. - Replaced a previously commented-out special-case
System.ValueTuplecondition with a negatedifaround the version-mismatch error logging.
rainersigwald
approved these changes
Jan 27, 2026
rainersigwald
approved these changes
Jan 27, 2026
JaclynCodes
added a commit
to JaclynCodes/msbuild
that referenced
this pull request
Jan 28, 2026
This reverts commit 211a2e1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13082
Context
removing a commented out code as described in the ticket.