Skip to content

Avoid SolutionConfiguration dictionary resizing #12160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JanProvaznik merged 3 commits into from
Aug 25, 2025
Merged

Avoid SolutionConfiguration dictionary resizing #12160

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6ce3a8
Avoid SolutionConfiguration dictionary resizing
Erarndt Jul 11, 2025
3b15db8
Merge branch 'main' of https://github.com/dotnet/msbuild into dev/era…
Erarndt Aug 18, 2025
50c0148
PR feedback
Erarndt Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions src/Shared/SolutionConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,19 +20,19 @@ internal sealed class SolutionConfiguration
public static readonly char[] ConfigPlatformSeparator = { '|' };

// This field stores pre-cached project elements for project guids for quicker access by project guid
private readonly Dictionary<string, XmlElement> _cachedProjectElements = new Dictionary<string, XmlElement>(StringComparer.OrdinalIgnoreCase);
private readonly Dictionary<string, XmlElement> _cachedProjectElements;

// This field stores pre-cached project elements for project guids for quicker access by project absolute path
private readonly Dictionary<string, XmlElement> _cachedProjectElementsByAbsolutePath = new Dictionary<string, XmlElement>(StringComparer.OrdinalIgnoreCase);
private readonly Dictionary<string, XmlElement> _cachedProjectElementsByAbsolutePath;

// This field stores the project absolute path for quicker access by project guid
private readonly Dictionary<string, string> _cachedProjectAbsolutePathsByGuid = new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase);
private readonly Dictionary<string, string> _cachedProjectAbsolutePathsByGuid;

// This field stores the project guid for quicker access by project absolute path
private readonly Dictionary<string, string> _cachedProjectGuidsByAbsolutePath = new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase);
private readonly Dictionary<string, string> _cachedProjectGuidsByAbsolutePath;

// This field stores the list of dependency project guids by depending project guid
private readonly Dictionary<string, List<string>> _cachedDependencyProjectGuidsByDependingProjectGuid = new Dictionary<string, List<string>>(StringComparer.OrdinalIgnoreCase);
private readonly Dictionary<string, List<string>> _cachedDependencyProjectGuidsByDependingProjectGuid;

public SolutionConfiguration(string xmlString)
{
Expand All @@ -47,6 +47,14 @@ public SolutionConfiguration(string xmlString)
XmlNodeList? projectConfigurationElements = GetProjectConfigurations(xmlString);
if (projectConfigurationElements != null)
{
int projectConfigurationCount = projectConfigurationElements.Count;

_cachedProjectElements = new Dictionary<string, XmlElement>(projectConfigurationCount, StringComparer.OrdinalIgnoreCase);
_cachedProjectElementsByAbsolutePath = new Dictionary<string, XmlElement>(projectConfigurationCount, StringComparer.OrdinalIgnoreCase);
_cachedProjectAbsolutePathsByGuid = new Dictionary<string, string>(projectConfigurationCount, StringComparer.OrdinalIgnoreCase);
_cachedProjectGuidsByAbsolutePath = new Dictionary<string, string>(projectConfigurationCount, StringComparer.OrdinalIgnoreCase);
_cachedDependencyProjectGuidsByDependingProjectGuid = new Dictionary<string, List<string>>(projectConfigurationCount, StringComparer.OrdinalIgnoreCase);

Comment thread
Erarndt marked this conversation as resolved.
foreach (XmlElement xmlElement in projectConfigurationElements)
{
string projectGuid = xmlElement.GetAttribute(ProjectAttribute);
Expand Down Expand Up @@ -101,6 +109,14 @@ public SolutionConfiguration(string xmlString)
}
}
}
else
{
_cachedProjectElements = new Dictionary<string, XmlElement>(StringComparer.OrdinalIgnoreCase);
_cachedProjectElementsByAbsolutePath = new Dictionary<string, XmlElement>(StringComparer.OrdinalIgnoreCase);
_cachedProjectAbsolutePathsByGuid = new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase);
_cachedProjectGuidsByAbsolutePath = new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase);
_cachedDependencyProjectGuidsByDependingProjectGuid = new Dictionary<string, List<string>>(StringComparer.OrdinalIgnoreCase);
}
}

public static SolutionConfiguration Empty { get; } = new SolutionConfiguration(string.Empty);
Expand Down