Avoid SolutionConfiguration dictionary resizing #12160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR pre-allocates internal dictionaries in SolutionConfiguration using the known number of project configurations to reduce resizing overhead.
- Removed inline field initializers and moved dictionary construction into the constructor.
- Used
projectConfigurationElements.Countas the initial capacity when building dictionaries. - Added an
elsebranch to ensure dictionaries are always initialized (even when there are no configurations).
rainersigwald
previously requested changes
Jul 23, 2025
Member
rainersigwald
left a comment
rainersigwald
left a comment
There was a problem hiding this comment.
If the zero/default size will work I'd sure like to have the deduplication.
…rndt/solutionConfigDicts
SimaTian
approved these changes
Aug 25, 2025
JanProvaznik
approved these changes
Aug 25, 2025
JanProvaznik
pushed a commit
that referenced
this pull request
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Context
The
SolutionConfigurationclass has several internal dictionaries that are allocated and populated in the constructor. No size information is given, so there are resizing allocations that happen that can be minimized.Before:
After:
Changes Made
Testing
Notes