Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jun 6, 2025

I detected changes in the vs17.11 branch which have not been merged yet to vs17.12. I'm a robot and am configured to help you automatically keep vs17.12 up to date, so I've opened this PR.

This PR merges commits made on vs17.11 by the following committers:

Instructions for merging from UI

This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.

merge button instructions

If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.

Instructions for merging via command line

Run these commands to merge this pull request from the command line.

git fetch
git checkout vs17.11
git pull --ff-only
git checkout vs17.12
git pull --ff-only
git merge --no-ff vs17.11

# If there are merge conflicts, resolve them and then run git merge --continue to complete the merge
# Pushing the changes to the PR branch will re-trigger PR validation.
git push https://github.com/dotnet/msbuild HEAD:merge/vs17.11-to-vs17.12
or if you are using SSH
git push [email protected]:dotnet/msbuild HEAD:merge/vs17.11-to-vs17.12

After PR checks are complete push the branch

git push

Instructions for resolving conflicts

⚠️ If there are merge conflicts, you will need to resolve them manually before merging. You can do this using GitHub or using the command line.

Instructions for updating this pull request

Contributors to this repo have permission update this pull request by pushing to the branch 'merge/vs17.11-to-vs17.12'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.
The provided examples assume that the remote is named 'origin'. If you have a different remote name, please replace 'origin' with the name of your remote.

git fetch
git checkout -b merge/vs17.11-to-vs17.12 origin/vs17.12
git pull https://github.com/dotnet/msbuild merge/vs17.11-to-vs17.12
(make changes)
git commit -m "Updated PR with my changes"
git push https://github.com/dotnet/msbuild HEAD:merge/vs17.11-to-vs17.12
or if you are using SSH
git fetch
git checkout -b merge/vs17.11-to-vs17.12 origin/vs17.12
git pull [email protected]:dotnet/msbuild merge/vs17.11-to-vs17.12
(make changes)
git commit -m "Updated PR with my changes"
git push [email protected]:dotnet/msbuild HEAD:merge/vs17.11-to-vs17.12

Contact .NET Core Engineering (dotnet/dnceng) if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/main/.github/workflows/scripts/inter-branch-merge.ps1.

dotnet-maestro bot and others added 30 commits March 18, 2025 09:11
* Update dependencies from https://github.com/dotnet/arcade build 20250220.1

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25114.5 -> To Version 8.0.0-beta.25120.1

* Update Versions.props VersionPrefix

* Update dependencies from https://github.com/dotnet/arcade build 20250314.5

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25114.5 -> To Version 8.0.0-beta.25164.5

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Jenny Bai <[email protected]>
* Update dependencies from https://github.com/dotnet/arcade build 20250220.1

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25114.5 -> To Version 8.0.0-beta.25120.1

* Update Versions.props VersionPrefix

* Update dependencies from https://github.com/dotnet/arcade build 20250314.5

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25114.5 -> To Version 8.0.0-beta.25164.5

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Jenny Bai <[email protected]>
* remove release branding for experimental in CI Build

* backport experimental insertion and add servicing branch selection logic

* fix removing versionkind

* bump version

* simplify version suffix selection

* fix comment
changes in the vs17.8 branch which have not been merged yet to vs17.10
* Update dependencies from https://github.com/dotnet/arcade build 20250404.7

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25164.5 -> To Version 8.0.0-beta.25204.7

* Update Versions.props

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Jenny Bai <[email protected]>
* Update dependencies from https://github.com/dotnet/arcade build 20250404.7

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25111.4 -> To Version 8.0.0-beta.25204.7

* Update Versions.props VersionPrefix

* Update PreReleaseVersionLabel to 'servicing'

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Jenny Bai <[email protected]>
Co-authored-by: YuliiaKovalova <[email protected]>
* Update dependencies from https://github.com/dotnet/arcade build 20250408.7

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25204.7 -> To Version 8.0.0-beta.25208.7

* Update VersionPrefix to 17.8.26

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Gang Wang <[email protected]>
* Update dependencies from https://github.com/dotnet/arcade build 20250408.7

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25204.7 -> To Version 8.0.0-beta.25208.7

* Update VersionPrefix to 17.10.27

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Gang Wang <[email protected]>
DownloadFile should not rely on the remote server response headers. Unless the DestinationFileName task parameter is specified - let's just fallback to the request URI - which is as well the publicly documented behavior.
DownloadFile should not rely on the remote server response headers. Unless the DestinationFileName task parameter is specified - let's just fallback to the request URI - which is as well the publicly documented behavior.
…nse headers

DownloadFile should not rely on the remote server response headers. Unless the DestinationFileName task parameter is specified - let's just fallback to the request URI - which is as well the publicly documented behavior

----
#### AI description  (iteration 1)
#### PR Classification
Bug fix to ensure `DownloadFile` does not rely on response headers for file name determination.

#### PR Summary
This pull request modifies the `DownloadFile` task to avoid using response headers for determining the file name, instead relying on the request URI.
- Changes in `src/Tasks/DownloadFile.cs` to use `requestUri` instead of `response` for file name extraction.
- Updated method signature and logic in `TryGetFileName` to handle `requestUri`.
<!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
* Update dependencies from https://github.com/dotnet/arcade build 20250408.7

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25204.7 -> To Version 8.0.0-beta.25208.7

* Update VersionPrefix to 17.11.31

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Gang Wang <[email protected]>
revert 10725 to unblock VS insertions by matching 17.8 VS versions.
We're doing a version bump so all branches have up-to-date opt-prof runs.

[Opt-prof version](https://dev.azure.com/devdiv/_apps/hub/ms-vscs-artifact.build-tasks.drop-hub-group-explorer-hub?name=OptimizationData/DotNet-msbuild-Trusted/internal/vs17.8/20250416.5/11417138/1)

----
#### AI description  (iteration 1)
#### PR Classification
Version update.

#### PR Summary
This pull request updates the version prefix in the project configuration.
- `eng/Versions.props`: Updated `<VersionPrefix>` from `17.8.28` to `17.8.29`.
<!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
We're doing a version bump so all branches have up-to-date opt-prof runs.

[OptProf data](https://dev.azure.com/devdiv/_apps/hub/ms-vscs-artifact.build-tasks.drop-hub-group-explorer-hub?name=OptimizationData/DotNet-msbuild-Trusted/internal/vs17.10/20250422.7/11449768/1)

----
#### AI description  (iteration 1)
#### PR Classification
Version bump.

#### PR Summary
This pull request updates the version prefix in the project configuration file to reflect a new release version.
- `eng/Versions.props`: Updated `<VersionPrefix>` from `17.10.28` to `17.10.29`.
<!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
Fixes #

### Context


### Changes Made


### Testing


### Notes
Fixes #

### Context


### Changes Made


### Testing


### Notes
* Update dependencies from https://github.com/dotnet/arcade build 20250414.7

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25208.7 -> To Version 8.0.0-beta.25214.7

* Update VersionPrefix to 17.8.27

* Update dependencies from https://github.com/dotnet/arcade build 20250425.5

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25208.7 -> To Version 8.0.0-beta.25225.5

* Update dependencies from https://github.com/dotnet/arcade build 20250430.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25208.7 -> To Version 8.0.0-beta.25230.1

* Update dependencies from https://github.com/dotnet/arcade build 20250513.4

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25208.7 -> To Version 8.0.0-beta.25263.4

* Update dependencies from https://github.com/dotnet/arcade build 20250514.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25208.7 -> To Version 8.0.0-beta.25264.2

* bump VersionPrefix to 17.8.30

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Gang Wang <[email protected]>
Co-authored-by: Surayya Huseyn Zada <[email protected]>
Co-authored-by: Surayya Huseyn Zada <[email protected]>
dotnet-maestro bot and others added 7 commits May 28, 2025 09:38
* Update dependencies from https://github.com/dotnet/arcade build 20250414.7

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25208.7 -> To Version 8.0.0-beta.25214.7

* Update VersionPrefix to 17.10.28

* Update dependencies from https://github.com/dotnet/arcade build 20250425.5

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25208.7 -> To Version 8.0.0-beta.25225.5

* Update dependencies from https://github.com/dotnet/arcade build 20250430.1

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25208.7 -> To Version 8.0.0-beta.25230.1

* Update dependencies from https://github.com/dotnet/arcade build 20250513.4

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25208.7 -> To Version 8.0.0-beta.25263.4

* Update dependencies from https://github.com/dotnet/arcade build 20250514.2

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25208.7 -> To Version 8.0.0-beta.25264.2

* bump VersionPrefix to 17.10.30

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Gang Wang <[email protected]>
Co-authored-by: Surayya Huseyn Zada <[email protected]>
Co-authored-by: Surayya Huseyn Zada <[email protected]>
This pull request updates the following dependencies

[marker]: <> (Begin:aca86521-13b3-4d28-a005-127af3b681e5)
## From https://github.com/dotnet/arcade
- **Subscription**:
[aca86521-13b3-4d28-a005-127af3b681e5](https://maestro.dot.net/subscriptions?search=aca86521-13b3-4d28-a005-127af3b681e5)
- **Build**:
[20250514.2](https://dev.azure.com/dnceng/internal/_build/results?buildId=2709666)
- **Date Produced**: May 15, 2025 7:32:15 AM UTC
- **Commit**:
[983d15077d88cfed26837e40e8f984fdee5d1715](dotnet/arcade@983d150)
- **Branch**: refs/heads/release/8.0

[DependencyUpdate]: <> (Begin)

- **Updates**:
- **Microsoft.SourceBuild.Intermediate.arcade**: [from
8.0.0-beta.25208.7 to 8.0.0-beta.25264.2][5]
- **Microsoft.DotNet.Arcade.Sdk**: [from 8.0.0-beta.25208.7 to
8.0.0-beta.25264.2][5]
- **Microsoft.DotNet.XUnitExtensions**: [from 8.0.0-beta.25208.7 to
8.0.0-beta.25264.2][5]

[5]: dotnet/arcade@c7a36e5...983d150

[DependencyUpdate]: <> (End)


[marker]: <> (End:aca86521-13b3-4d28-a005-127af3b681e5)
I detected changes in the vs17.8 branch which have not been merged yet
to vs17.10. I'm a robot and am configured to help you automatically keep
vs17.10 up to date, so I've opened this PR.

This PR merges commits made on vs17.8 by the following committers:

* @surayya-MS
* @rainersigwald
* @dotnet-maestro[bot]

## Instructions for merging from UI

This PR will not be auto-merged. When pull request checks pass, complete
this PR by creating a merge commit, *not* a squash or rebase commit.

<img alt="merge button instructions"
src="https://i.imgur.com/GepcNJV.png" width="300" />

If this repo does not allow creating merge commits from the GitHub UI,
use command line instructions.

## Instructions for merging via command line

Run these commands to merge this pull request from the command line.

``` sh
git fetch
git checkout vs17.8
git pull --ff-only
git checkout vs17.10
git pull --ff-only
git merge --no-ff vs17.8

# If there are merge conflicts, resolve them and then run git merge --continue to complete the merge
# Pushing the changes to the PR branch will re-trigger PR validation.
git push https://github.com/dotnet/msbuild HEAD:merge/vs17.8-to-vs17.10
```

<details>
<summary>or if you are using SSH</summary>

```
git push [email protected]:dotnet/msbuild HEAD:merge/vs17.8-to-vs17.10
```

</details>


After PR checks are complete push the branch
```
git push
```

## Instructions for resolving conflicts

:warning: If there are merge conflicts, you will need to resolve them
manually before merging. You can do this [using GitHub][resolve-github]
or using the [command line][resolve-cli].

[resolve-github]:
https://help.github.com/articles/resolving-a-merge-conflict-on-github/
[resolve-cli]:
https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/

## Instructions for updating this pull request

Contributors to this repo have permission update this pull request by
pushing to the branch 'merge/vs17.8-to-vs17.10'. This can be done to
resolve conflicts or make other changes to this pull request before it
is merged.
The provided examples assume that the remote is named 'origin'. If you
have a different remote name, please replace 'origin' with the name of
your remote.

```
git fetch
git checkout -b merge/vs17.8-to-vs17.10 origin/vs17.10
git pull https://github.com/dotnet/msbuild merge/vs17.8-to-vs17.10
(make changes)
git commit -m "Updated PR with my changes"
git push https://github.com/dotnet/msbuild HEAD:merge/vs17.8-to-vs17.10
```

<details>
    <summary>or if you are using SSH</summary>

```
git fetch
git checkout -b merge/vs17.8-to-vs17.10 origin/vs17.10
git pull [email protected]:dotnet/msbuild merge/vs17.8-to-vs17.10
(make changes)
git commit -m "Updated PR with my changes"
git push [email protected]:dotnet/msbuild HEAD:merge/vs17.8-to-vs17.10
```

</details>

Contact .NET Core Engineering (dotnet/dnceng) if you have questions or
issues.
Also, if this PR was generated incorrectly, help us fix it. See
https://github.com/dotnet/arcade/blob/main/.github/workflows/scripts/inter-branch-merge.ps1.
@github-actions github-actions bot force-pushed the merge/vs17.11-to-vs17.12 branch from 3d06c70 to adc7800 Compare June 6, 2025 14:58
@github-actions github-actions bot requested a review from a team as a code owner June 6, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants