[vs17.10] Merge tag v17.10.29 #11865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DownloadFile should not rely on the remote server response headers. Unless the DestinationFileName task parameter is specified - let's just fallback to the request URI - which is as well the publicly documented behavior.
We're doing a version bump so all branches have up-to-date opt-prof runs. [OptProf data](https://dev.azure.com/devdiv/_apps/hub/ms-vscs-artifact.build-tasks.drop-hub-group-explorer-hub?name=OptimizationData/DotNet-msbuild-Trusted/internal/vs17.10/20250422.7/11449768/1) ---- #### AI description (iteration 1) #### PR Classification Version bump. #### PR Summary This pull request updates the version prefix in the project configuration file to reflect a new release version. - `eng/Versions.props`: Updated `<VersionPrefix>` from `17.10.28` to `17.10.29`. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates version numbers and binding redirects while modifying filename resolution logic in the download task. Key changes include:
- Switching from response-based to URI-based filename extraction in DownloadFile.cs.
- Adjusting binding redirects and dependency version numbers in configuration files.
- Updating version properties and dependency details to reflect the new v17.10.29 release.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Tasks/DownloadFile.cs | Changed filename extraction logic to rely on request URI instead of response headers. |
| src/MSBuild/app.config | Removed the Microsoft.IO.Redist dependent assembly and updated the System.Text.Json binding redirect. |
| src/MSBuild/app.amd64.config | Updated binding redirects for Microsoft.IO.Redist and System.Text.Json. |
| eng/Versions.props | Bumped VersionPrefix and updated several dependency versions. |
| eng/Version.Details.xml | Updated dependency details for System.Text.Json and Microsoft.DotNet.XUnitExtensions. |
| eng/SourceBuildPrebuiltBaseline.xml | Updated usage patterns for System.Formats.Asn1 and System.Text.Json to new versions. |
| eng/Packages.props | Removed the package version reference for System.Formats.Asn1. |
Contributor
|
Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version. |
Member
Author
|
|
surayya-MS
force-pushed
the
msbuild/vs17.10
branch
from
40ce8b8 to
27f9d42
Compare
Member
Author
|
As discussed offline, disabling bootstrap |
surayya-MS
commented
May 22, 2025
surayya-MS
force-pushed
the
msbuild/vs17.10
branch
3 times, most recently
from
a6d923c to
e9e1e8d
Compare
surayya-MS
force-pushed
the
msbuild/vs17.10
branch
from
130a625 to
37f4df2
Compare
rainersigwald
approved these changes
May 23, 2025
Member
rainersigwald
left a comment
rainersigwald
left a comment
There was a problem hiding this comment.
LGTM. Please merge, do not squash.
JanProvaznik
approved these changes
May 26, 2025
GangWang01
added a commit
to GangWang01/msbuild
that referenced
this pull request
Aug 6, 2025
GangWang01
added a commit
to GangWang01/msbuild
that referenced
this pull request
Aug 6, 2025
GangWang01
added a commit
to GangWang01/msbuild
that referenced
this pull request
Aug 6, 2025
GangWang01
added a commit
to GangWang01/msbuild
that referenced
this pull request
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Context
Changes Made
Testing
Notes