Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion src/Build/BackEnd/Components/RequestBuilder/Lookup.cs
Original file line number Diff line number Diff line change
Expand Up @@ -858,7 +858,31 @@ private static void ApplyMetadataModificationsToItem(MetadataModifications modif
// or if keepOnlySpecified == true and there is no entry for that name.
if (modificationsToApply.KeepOnlySpecified)
{
List<string> metadataToRemove = new List<string>(itemToModify.Metadata.Where(m => modificationsToApply[m.Name].Remove).Select(m => m.Name));

// Perf: Avoid boxing when possible by getting the underlying struct enumerator if available.
List<string> metadataToRemove = new List<string>(); ;
if (itemToModify.Metadata is CopyOnWritePropertyDictionary<ProjectMetadataInstance> copyOnWritePropertyMetadata)
{
foreach (var m in copyOnWritePropertyMetadata)
{
string name = m.Value.Name;
if (modificationsToApply[name].Remove)
{
metadataToRemove.Add(name);
}
}
}
else
{
foreach (var m in itemToModify.Metadata)
{
if (modificationsToApply[m.Name].Remove)
{
metadataToRemove.Add(m.Name);
}
}
}

foreach (var metadataName in metadataToRemove)
{
itemToModify.RemoveMetadata(metadataName);
Expand Down