remove some closures as well as boxing from enumerator #11942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Optimizes metadata removal in ApplyMetadataModificationsToItem by replacing the LINQ-based approach with manual loops to eliminate closures and avoid boxing when iterating over CopyOnWritePropertyDictionary.
- Replaced a single LINQ call with explicit
foreachloops - Added special handling for
CopyOnWritePropertyDictionary<ProjectMetadataInstance>to leverage its struct enumerator
Member
|
In general for this class of issue, I'm willing to accept on faith that there are allocating constructs--what is interesting is how allocatey the codepath is relative to full execution. Can you focus on that in the motivation for future PRs? |
rainersigwald
approved these changes
Jun 4, 2025
Co-authored-by: Copilot <[email protected]>
SimaTian
reviewed
Jun 5, 2025
YuliiaKovalova
approved these changes
Jun 5, 2025
…y bigger allocation of list, leaving as default allocation size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # Captures that lead to allocations.
Context
Based on a trace was able to see that allocations from captures that were from using linq without the correct context.
Changes Made
Manually created a list instead of using the where clause to create one.
Also moved over to grabbing the underlying struct enumerator when possible to avoid boxing.
Testing
Looked at the dll in ILSPY to verify change in closures.
Before. (Display Class shows a capture)
After (no more DisplayClass)
Notes