Remove duplicate @ prefix from issueAuthor in GitOps#34834
Conversation
https://github.com/GitOps-microsoft/GitOps.PullRequestIssueManagement/pull/262 (internal Microsoft link) changed the `${issueAuthor}` placeholder to include the `@` character. Remove the one we added so we don't duplicate it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 34834Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 34834" |
There was a problem hiding this comment.
Pull request overview
Updates the GitOps issue/PR management policy replies to avoid duplicating the @ prefix now that ${issueAuthor} includes it, keeping automated messages correctly formatted.
Changes:
- Removed the hardcoded
@preceding${issueAuthor}in multiple reply templates. - Kept existing reply text/formatting otherwise unchanged.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
/review -b feature/refactor-copilot-yml |
MauiBot
added
s/agent-review-incomplete
s/agent-fix-pr-picked
|
@kubaflo this won't trigger AzDO builds, can you please force merge it? |
|
@rmarinho can you please merge this? |
|
/review -b feature/refactor-copilot-yml |
🤖 AI Summary
📊 Review Session —
|
| # | Source | Approach | Test Result | Files Changed | Notes |
|---|---|---|---|---|---|
| PR | PR #34834 | Remove hardcoded @ before ${issueAuthor} in affected GitOps replies and fix two wording typos |
⏳ PENDING (Gate skipped: no tests detected) | .github/policies/resourceManagement.yml |
Original PR |
🔬 Code Review — Deep Analysis
Code Review — PR #34834
Independent Assessment
What this changes: Removes literal @ before ${issueAuthor} in GitOps resource-management replies and fixes two user-facing text typos in .github/policies/resourceManagement.yml.
Inferred motivation: Avoid duplicated mentions if ${issueAuthor} now expands with @.
Reconciliation with PR Narrative
Author claims: GitOps changed ${issueAuthor} to include @; this removes the extra prefix.
Agreement/disagreement: Matches the code. Similar no-@ usage exists in dotnet/aspnetcore. YAML validation passed.
Findings
No ❌ /
Devil's Advocate
Could not inspect the internal GitOps PR directly, so expansion behavior depends on the service claim. CI schema validation passes; no failed checks observed, but some checks are pending/neutral.
Verdict: LGTM
Confidence: medium
Summary: The changes are narrow, syntactically valid, and fix the intended duplicate-mention behavior plus wording issues. Wrote CustomAgentLogsTmp/PRState/34834/PRAgent/inline-findings.json as []; no GitHub comments posted.
🔧 Fix — Analysis & Comparison
Fix Candidates
| # | Source | Approach | Test Result | Files Changed | Notes |
|---|---|---|---|---|---|
| 1 | try-fix | Replace personalized ${issueAuthor} greetings with neutral greetings, removing the placeholder dependency entirely |
❌ FAIL | .github/policies/resourceManagement.yml |
YAML parsed and duplicate @${issueAuthor} pattern was gone, but the candidate lost explicit author mention/notification behavior. |
| 2 | try-fix | Use a hypothetical raw-login placeholder, @${issueAuthorLogin}, to preserve mention formatting without relying on ${issueAuthor} including @ |
❌ FAIL | .github/policies/resourceManagement.yml |
YAML parsed, but the placeholder is unsupported/speculative in this repo context and risks literal or invalid GitOps output. |
| PR | PR #34834 | Remove hardcoded @ before the known ${issueAuthor} placeholder and fix two wording typos |
.github/policies/resourceManagement.yml |
Original PR; best supported minimal fix. |
Cross-Pollination
| Model | Round | New Ideas? | Details |
|---|---|---|---|
| claude-opus-4.6 | 2 | No | NO NEW IDEAS: PR's surgical fix is the correct minimal change; alternatives are speculative or out of scope. |
| claude-opus-4.7 | 2 | No | NO NEW IDEAS: Given repo-supported placeholders, using ${issueAuthor} without hardcoded @ is the only robust fix. |
| gpt-5.3-codex | 2 | No | NO NEW IDEAS: Bare ${issueAuthor} preserves explicit mention and avoids @@username; other options lose functionality or add complexity. |
| gpt-5.5 | 2 | No | NO NEW IDEAS: PR fix is the minimal supported correction; alternatives lose notification behavior or rely on unsupported placeholders. |
Exhausted: Yes
Selected Fix: PR's fix — It preserves the known GitOps ${issueAuthor} placeholder, removes only the now-incorrect literal @, includes requested wording fixes, and avoids unsupported placeholder or behavior changes.
📋 Report — Final Recommendation
Comparative Candidate Report — PR #34834
Candidates Compared
| Rank | Candidate | Regression Result | Summary |
|---|---|---|---|
| 1 | pr |
Removes only the now-incorrect literal @ before the known ${issueAuthor} placeholder and fixes the two wording mistakes. Preserves author mention behavior without relying on unsupported tokens. |
|
| 2 | pr-plus-reviewer |
Equivalent to pr; the expert reviewer produced no actionable inline findings and no sandbox changes. Ranked behind pr only because it adds no improvement over the raw PR fix. |
|
| 3 | try-fix-1 |
❌ Fail | Replaces personalized greetings with neutral text. This removes duplicate mentions, but regresses explicit author mention/notification behavior that the PR preserves. |
| 4 | try-fix-2 |
❌ Fail | Uses @${issueAuthorLogin}, which would preserve mention shape only if that placeholder exists. No repository-local schema/docs establish it as supported, so it risks literal output or GitOps failure. |
Analysis
The pr and pr-plus-reviewer candidates are functionally identical because expert review found no actionable changes to apply. Both keep the known ${issueAuthor} placeholder in every affected reply and remove only the duplicated literal @, which directly addresses the reported GitOps behavior change while preserving author notification/personalization.
Both try-fix candidates failed regression probes and must rank below the PR-based candidates. try-fix-1 avoids the duplicate mention by removing the placeholder entirely, but that loses the explicit author mention. try-fix-2 keeps an explicit mention shape but depends on an unsupported/speculative ${issueAuthorLogin} placeholder.
Winner
Winning candidate: pr
pr wins because it is the minimal supported fix, preserves the existing GitOps placeholder contract, avoids the failed regressions in both try-fix alternatives, and requires no additional expert-review changes.
|
/azp run maui-pr-uitests,maui-pr-devicetests |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
### Description of Change https://github.com/GitOps-microsoft/GitOps.PullRequestIssueManagement/pull/262 (internal Microsoft link) changed the `${issueAuthor}` placeholder to include the `@` character. Remove the one we added so we don't duplicate it. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Description of Change
https://github.com/GitOps-microsoft/GitOps.PullRequestIssueManagement/pull/262 (internal Microsoft link) changed the
${issueAuthor}placeholder to include the@character.Remove the one we added so we don't duplicate it.