[Windows] Fix the control overlap issue in the AppThemeFeatureMatrix sample on candidate#34697
Merged
kubaflo merged 3 commits intodotnet:inflight/candidatefrom Mar 27, 2026
Merged
Conversation
dotnet-policy-service
bot
added
the
partner/syncfusion
Contributor
|
/azp run maui-pr-uitests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Mar 27, 2026
kubaflo
approved these changes
Mar 27, 2026
sheiksyedm
pushed a commit
that referenced
this pull request
Apr 4, 2026
…sample on candidate (#34697) ### Details PR #30538 fixes the Windows Switch control width issue, where it previously reserved unnecessary space inherited from WinUI’s ToggleSwitch default style. Due to this change, we need to re-save the existing switch images. Also the reduced Switch width, the grid columns in AppThemePage are rebalanced, causing the RadioButton (which has Grid.ColumnSpan="2") to overlap the Editor control on the right side. ### Description of Change: - Before: RadioButton had Grid.ColumnSpan="2", causing it to span both columns and overlap the Editor in Column 1 of the same row. - After: RadioButton is constrained to Grid.Column="0" only, so the Editor in Column 1 remains in its own cell without overlap. ### Failures caused by these PRs: #30538 - The Switch previously occupied the full width; now it takes only the required space. #30089 - The Slider previously appeared without a background color, now the background color is applied correctly. ### Screenshots | Before Issue Fix | After Issue Fix | |----------|----------| | <img width="300" height="600" src="https://github.com/user-attachments/assets/ac70ad29-f055-4870-b9b2-5a381f601254"> | <img width="300" height="600" src="https://github.com/user-attachments/assets/a06482bf-c0de-4c27-87be-d9d00a503723"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
PR #30538 fixes the Windows Switch control width issue, where it previously reserved unnecessary space inherited from WinUI’s ToggleSwitch default style.
Due to this change, we need to re-save the existing switch images.
Also the reduced Switch width, the grid columns in AppThemePage are rebalanced, causing the RadioButton (which has Grid.ColumnSpan="2") to overlap the Editor control on the right side.
Description of Change:
Before: RadioButton had Grid.ColumnSpan="2", causing it to span both columns and overlap the Editor in Column 1 of the same row.
After: RadioButton is constrained to Grid.Column="0" only, so the Editor in Column 1 remains in its own cell without overlap.
Failures caused by these PRs:
#30538 - The Switch previously occupied the full width; now it takes only the required space.
#30089 - The Slider previously appeared without a background color, now the background color is applied correctly.
Screenshots