-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[iOS] Fix tab bar unselected colors not rendering on iOS 26+ #34688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jfversluis
wants to merge
4
commits into
main
Choose a base branch
from
Fix-iOS-26-bugs-ff88
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7207ec9
Fix iOS 26+ tab bar unselected colors for TabbedPage and Shell
jfversluis 649c308
Debug: Add Console.WriteLine logging to trace text coloring execution
jfversluis 21b9908
Debug: Ultra-verbose logging for text color walkthrough
jfversluis 1ddb740
Clean up: Remove dead SetTitleTextAttributes(Normal) code for iOS 26+
jfversluis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,14 @@ | ||
| namespace Maui.Controls.Sample; | ||
| namespace Maui.Controls.Sample; | ||
|
|
||
| public partial class App : Application | ||
| { | ||
| public App() | ||
| { | ||
| InitializeComponent(); | ||
| } | ||
|
|
||
| protected override Window CreateWindow(IActivationState? activationState) | ||
| { | ||
| // To test shell scenarios, change this to true | ||
| bool useShell = false; | ||
| public App() | ||
| { | ||
| InitializeComponent(); | ||
| } | ||
|
|
||
| if (!useShell) | ||
| { | ||
| return new Window(new NavigationPage(new MainPage())); | ||
| } | ||
| else | ||
| { | ||
| return new Window(new SandboxShell()); | ||
| } | ||
| } | ||
| protected override Window CreateWindow(IActivationState? activationState) | ||
| { | ||
| return new Window(new SandboxShell()); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| <?xml version="1.0" encoding="utf-8" ?> | ||
| <ContentPage xmlns="http://schemas.microsoft.com/dotnet/2021/maui" | ||
| xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml" | ||
| x:Class="Maui.Controls.Sample.MainPage2" | ||
| Title="Settings"> | ||
| <Label Text="Settings Page" HorizontalOptions="Center" VerticalOptions="Center" /> | ||
| </ContentPage> |
9 changes: 9 additions & 0 deletions
9
src/Controls/samples/Controls.Sample.Sandbox/MainPage2.xaml.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| namespace Maui.Controls.Sample; | ||
|
|
||
| public partial class MainPage2 : ContentPage | ||
| { | ||
| public MainPage2() | ||
| { | ||
| InitializeComponent(); | ||
| } | ||
| } |
32 changes: 11 additions & 21 deletions
32
src/Controls/samples/Controls.Sample.Sandbox/SandboxShell.xaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,12 @@ | ||
| <Shell | ||
| xmlns="http://schemas.microsoft.com/dotnet/2021/maui" | ||
| xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml" | ||
| x:Class="Maui.Controls.Sample.SandboxShell" | ||
| xmlns:local="clr-namespace:Maui.Controls.Sample" | ||
| x:Name="shell"> | ||
| <TabBar Shell.TabBarForegroundColor="Green" | ||
| Shell.TabBarUnselectedColor="Red"> | ||
| <Tab Title="MainPage1" Icon="groceries.png"> | ||
| <ShellContent Icon="groceries.png" | ||
| Title="Home" | ||
| ContentTemplate="{DataTemplate local:MainPage}" | ||
| Route="MainPage" /> | ||
| </Tab> | ||
| <Tab Title="MainPage2" Icon="dotnet_bot.png"> | ||
| <ShellContent Icon="dotnet_bot.png" | ||
| Title="Home" | ||
| ContentTemplate="{DataTemplate local:MainPage}" | ||
| Route="MainPage2" /> | ||
| </Tab> | ||
| <?xml version="1.0" encoding="utf-8" ?> | ||
| <Shell xmlns="http://schemas.microsoft.com/dotnet/2021/maui" | ||
| xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml" | ||
| xmlns:local="clr-namespace:Maui.Controls.Sample" | ||
| x:Class="Maui.Controls.Sample.SandboxShell" | ||
| Shell.TabBarForegroundColor="Green" | ||
| Shell.TabBarUnselectedColor="Red"> | ||
| <TabBar> | ||
| <ShellContent Title="Home" ContentTemplate="{DataTemplate local:MainPage}" Icon="{OnPlatform iOS='house.fill', Default='house.png'}" /> | ||
| <ShellContent Title="Settings" ContentTemplate="{DataTemplate local:MainPage2}" Icon="{OnPlatform iOS='gear', Default='gear.png'}" /> | ||
| </TabBar> | ||
| </Shell> | ||
| </Shell> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the iOS 26+ early-return path,
_pendingSelectedTintColor/_pendingUnselectedTintColorare only set when the correspondingselectedColor/unselectedColoris non-null. If an app later removes these colors (e.g., dynamic resources revert to default), the pending fields andUITabBarproperties will keep reapplying the old values inUpdateLayout(), effectively making the colors “sticky”. Consider explicitly clearing the pending fields and restoringtabBar.TintColor/tabBar.UnselectedItemTintColorto the defaults when the effective colors are null/default.