Skip to content

Fix flaky UI tests with retryTimeout, crash recovery, and improved diagnostics #33705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmarinho merged 16 commits into from
Jan 28, 2026
Merged

Fix flaky UI tests with retryTimeout, crash recovery, and improved diagnostics #33705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
ea79f27
Fix flaky UI tests: SwipeView and ScrollView timing issues
PureWeen Jan 25, 2026
1301719
Fix flaky BoxView tests and tolerance regex bug
PureWeen Jan 25, 2026
ad38b6d
Fix flaky ShadowShouldUpdate and ChangingTranslation tests
PureWeen Jan 25, 2026
a919d32
Fix additional flaky screenshot tests
PureWeen Jan 26, 2026
0030bac
Add 4% tolerance to Issue10563 SwipeView screenshot tests
PureWeen Jan 26, 2026
2c2f744
Add retryTimeout parameter to VerifyScreenshot for flaky test fixes
PureWeen Jan 26, 2026
a3d3251
Add retryTimeout to Button, Border, Image feature tests
PureWeen Jan 26, 2026
f620c9d
Add retryTimeout to ViewBaseTests and Window tests
PureWeen Jan 26, 2026
224a525
Add retryTimeout to ALL feature tests
PureWeen Jan 27, 2026
bcaab4c
Remove Task.Delay anti-pattern from Issue24996 based on multi-model r…
PureWeen Jan 27, 2026
d070abd
Increase Issue32394 tolerance to 1.5% for CarouselView orientation ch…
PureWeen Jan 27, 2026
ebdd77f
Add longer timeouts to flaky CarouselView tests
PureWeen Jan 27, 2026
19d6c20
Add instrumentation crash detection and session recovery
PureWeen Jan 27, 2026
d94c8f9
Add retryTimeout to Issue10563 SwipeView screenshot tests
PureWeen Jan 27, 2026
e1731ec
Fix OneTimeSetUp diagnostic attachments not visible in Azure DevOps
PureWeen Jan 27, 2026
199e29f
Add retryTimeout to Issue27730 and Issue26662 visual tests
PureWeen Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/AbsoluteLayoutFeatureTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public void VerifyAbsoluteLayout_LayoutBounds()
App.Tap(LayoutFlagNoneCheckBox);
App.WaitForElement(Apply);
App.Tap(Apply);
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

[Test]
Expand All @@ -69,7 +69,7 @@ public void VerifyAbsoluteLayout_WidthAndHeight()
App.Tap(LayoutFlagNoneCheckBox);
App.WaitForElement(Apply);
App.Tap(Apply);
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

[Test]
Expand All @@ -91,7 +91,7 @@ public void VerifyAbsoluteLayout_XProportional()
App.Tap(LayoutFlagXProportionalCheckBox);
App.WaitForElement(Apply);
App.Tap(Apply);
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

[Test]
Expand All @@ -113,7 +113,7 @@ public void VerifyAbsoluteLayout_YProportional()
App.Tap(LayoutFlagYProportionalCheckBox);
App.WaitForElement(Apply);
App.Tap(Apply);
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

[Test]
Expand All @@ -140,7 +140,7 @@ public void VerifyAbsoluteLayout_XProportionalAndYProportional()
App.Tap(LayoutFlagYProportionalCheckBox);
App.WaitForElement(Apply);
App.Tap(Apply);
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

[Test]
Expand All @@ -165,7 +165,7 @@ public void VerifyAbsoluteLayout_PositionProportional()
App.Tap(LayoutFlagPositionProportionalCheckBox);
App.WaitForElement(Apply);
App.Tap(Apply);
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

[Test]
Expand All @@ -184,7 +184,7 @@ public void VerifyAbsoluteLayout_WidthProportional()
App.Tap(LayoutFlagWidthProportionalCheckBox);
App.WaitForElement(Apply);
App.Tap(Apply);
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

[Test]
Expand All @@ -203,7 +203,7 @@ public void VerifyAbsoluteLayout_HeightProportional()
App.Tap(LayoutFlagHeightProportionalCheckBox);
App.WaitForElement(Apply);
App.Tap(Apply);
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

[Test]
Expand All @@ -224,7 +224,7 @@ public void VerifyAbsoluteLayout_WidthProportionalAndHeightProportional()
App.Tap(LayoutFlagWidthProportionalCheckBox);
App.WaitForElement(Apply);
App.Tap(Apply);
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

[Test]
Expand All @@ -243,7 +243,7 @@ public void VerifyAbsoluteLayout_SizeProportional()
App.Tap(LayoutFlagSizeProportionalCheckBox);
App.WaitForElement(Apply);
App.Tap(Apply);
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

[Test]
Expand All @@ -262,7 +262,7 @@ public void VerifyAbsoluteLayout_SizeProportionalWithMaximumValue()
App.Tap(LayoutFlagSizeProportionalCheckBox);
App.WaitForElement(Apply);
App.Tap(Apply);
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

[Test]
Expand All @@ -287,7 +287,7 @@ public void VerifyAbsoluteLayout_AllProportional()
App.Tap(LayoutFlagAllCheckBox);
App.WaitForElement(Apply);
App.Tap(Apply);
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

[Test]
Expand All @@ -314,7 +314,7 @@ public void VerifyAbsoluteLayout_SizeProportionalAndPositionProportional()
App.Tap(LayoutFlagPositionProportionalCheckBox);
App.WaitForElement(Apply);
App.Tap(Apply);
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

[Test]
Expand All @@ -333,7 +333,7 @@ public void VerifyAbsoluteLayout_FlowDirection()
App.Tap("FlowDirectionRTL");
App.WaitForElement(Apply);
App.Tap(Apply);
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

[Test]
Expand All @@ -346,7 +346,7 @@ public void VerifyAbsoluteLayout_Visibility()
App.Tap("IsVisibleFalse");
App.WaitForElement(Apply);
App.Tap(Apply);
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

#if TEST_FAILS_ON_IOS && TEST_FAILS_ON_CATALYST // Issue Link: https://github.com/dotnet/maui/issues/31496
Expand All @@ -360,7 +360,7 @@ public void VerifyAbsoluteLayout_BackgroundColor()
App.Tap("BackgroundColorGrayButton");
App.WaitForElement(Apply);
App.Tap(Apply);
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

[Test]
Expand Down Expand Up @@ -388,7 +388,7 @@ public void VerifyAbsoluteLayout_Reset_LayoutBounds()
App.WaitForElement(XEntry);
App.WaitForElement(Apply);
App.Tap(Apply);
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}
#endif
}
42 changes: 21 additions & 21 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/AppThemeFeatureTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public void VerifyScreenshotWithPlatformCropping()
#if IOS
VerifyScreenshot(cropBottom: 1200);
#else
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
#endif
}

Expand All @@ -28,7 +28,7 @@ public void LightTheme_VerifyVisualState()
{
App.WaitForElement("DefaultLightThemeButton");
App.Tap("DefaultLightThemeButton");
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

[Test, Order(2)]
Expand All @@ -37,7 +37,7 @@ public void DarkTheme_VerifyVisualState()
{
App.WaitForElement("DefaultDarkThemeButton");
App.Tap("DefaultDarkThemeButton");
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

[Test, Order(3)]
Expand All @@ -52,7 +52,7 @@ public void LightTheme_CheckBox_VerifyVisualState()
App.Tap("LightThemeButton");
App.WaitForElement("CheckBox");
App.Tap("CheckBox");
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

[Test, Order(4)]
Expand All @@ -64,7 +64,7 @@ public void DarkTheme_CheckBox_VerifyVisualState()
App.WaitForElement("CheckBox");
App.Tap("CheckBox");
App.Tap("CheckBox");
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

[Test, Order(5)]
Expand All @@ -83,7 +83,7 @@ public void LightTheme_DatePicker_VerifyVisualState()
App.Tap("DatePicker");
App.Tap("22");
#endif
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

[Test, Order(6)]
Expand All @@ -102,7 +102,7 @@ public void DarkTheme_DatePicker_VerifyVisualState()
App.Tap("DatePicker");
App.Tap("23");
#endif
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

[Test, Order(7)]
Expand All @@ -111,7 +111,7 @@ public void LightTheme_RadioButton_VerifyVisualState()
{
App.WaitForElement("LightThemeButton");
App.Tap("LightThemeButton");
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

[Test, Order(8)]
Expand All @@ -122,7 +122,7 @@ public void DarkTheme_RadioButton_VerifyVisualState()
App.Tap("DarkThemeButton");
App.WaitForElement("RadioButton_Cat");
App.Tap("RadioButton_Cat");
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

#if TEST_FAILS_ON_IOS && TEST_FAILS_ON_CATALYST
Expand All @@ -137,7 +137,7 @@ public void LightTheme_Picker_VerifyVisualState()
App.Tap("Picker");
App.WaitForElement("Blue Monkey");
App.Tap("Blue Monkey");
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

[Test, Order(10)]
Expand All @@ -150,7 +150,7 @@ public void DarkTheme_Picker_VerifyVisualState()
App.Tap("Picker");
App.WaitForElement("Howler Monkey");
App.Tap("Howler Monkey");
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}
#endif

Expand All @@ -161,7 +161,7 @@ public void LightTheme_Slider_VerifyVisualState()
App.WaitForElement("LightThemeButton");
App.Tap("LightThemeButton");
App.WaitForElement("Slider");
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

[Test, Order(12)]
Expand All @@ -171,7 +171,7 @@ public void DarkTheme_Slider_VerifyVisualState()
App.WaitForElement("DarkThemeButton");
App.Tap("DarkThemeButton");
App.WaitForElement("Slider");
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

[Test, Order(13)]
Expand All @@ -182,7 +182,7 @@ public void LightTheme_Switch_VerifyVisualState()
App.Tap("LightThemeButton");
App.WaitForElement("Switch");
App.Tap("Switch");
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

[Test, Order(14)]
Expand All @@ -194,7 +194,7 @@ public void DarkTheme_Switch_VerifyVisualState()
App.WaitForElement("Switch");
App.Tap("Switch");
App.Tap("Switch");
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

#if TEST_FAILS_ON_ANDROID && TEST_FAILS_ON_IOS && TEST_FAILS_ON_WINDOWS && TEST_FAILS_ON_CATALYST // Issue Link - https://github.com/dotnet/maui/issues/30837
Expand All @@ -219,7 +219,7 @@ public void LightTheme_TimePicker_VerifyVisualState()
App.WaitForElement("AcceptButton");
App.Tap("AcceptButton");
#endif
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

[Test, Order(16)]
Expand All @@ -242,7 +242,7 @@ public void DarkTheme_TimePicker_VerifyVisualState()
App.WaitForElement("AcceptButton");
App.Tap("AcceptButton");
#endif
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}
#endif

Expand All @@ -253,7 +253,7 @@ public void LightTheme_SearchBar_VerifyVisualState()
App.WaitForElement("LightThemeButton");
App.Tap("LightThemeButton");
App.WaitForElement("SearchBar");
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

[Test, Order(18)]
Expand All @@ -263,7 +263,7 @@ public void DarkTheme_SearchBar_VerifyVisualState()
App.WaitForElement("DarkThemeButton");
App.Tap("DarkThemeButton");
App.WaitForElement("SearchBar");
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

[Test, Order(19)]
Expand All @@ -273,7 +273,7 @@ public void LightTheme_Editor_VerifyVisualState()
App.WaitForElement("LightThemeButton");
App.Tap("LightThemeButton");
App.WaitForElement("Editor");
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

[Test, Order(20)]
Expand All @@ -283,7 +283,7 @@ public void DarkTheme_Editor_VerifyVisualState()
App.WaitForElement("DarkThemeButton");
App.Tap("DarkThemeButton");
App.WaitForElement("Editor");
VerifyScreenshot();
VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));
}

#if TEST_FAILS_ON_ANDROID && TEST_FAILS_ON_CATALYST && TEST_FAILS_ON_IOS && TEST_FAILS_ON_WINDOWS //Issue Link - https://github.com/dotnet/maui/issues/19997
Expand Down
Loading
Loading