Skip to content

Set the CV2 handlers as the default#33177

Merged
PureWeen merged 2 commits intodotnet:inflight/currentfrom
Ahamed-Ali:CV2HandlersDefault
Dec 30, 2025
Merged

Set the CV2 handlers as the default#33177
PureWeen merged 2 commits intodotnet:inflight/currentfrom
Ahamed-Ali:CV2HandlersDefault

Conversation

@Ahamed-Ali
Copy link
Contributor

@Ahamed-Ali Ahamed-Ali commented Dec 16, 2025

Description of Change

To make CV2 handlers the default, set cv2handlers to true.

(i.e) when we use CollectionView / CarouselView = > CollectionViewHandler2 and CarouselViewHandler2 are used by default.

Explicitly setting CollectionView1/CarouselView1 or CollectionView2/CarouselView2 will configure the corresponding handlers correctly, as before.

@dotnet-policy-service dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Dec 16, 2025
@Ahamed-Ali Ahamed-Ali added area-testing Unit tests, device tests community ✨ Community Contribution labels Dec 16, 2025
@Ahamed-Ali Ahamed-Ali changed the title Make the Cv2 handlers default one Set the CV2 handlers as the default Dec 16, 2025
@sheiksyedm sheiksyedm marked this pull request as ready for review December 16, 2025 10:50
Copilot AI review requested due to automatic review settings December 16, 2025 10:50
Copilot AI reviewed Dec 16, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes CollectionViewHandler2 and CarouselViewHandler2 the default handlers for iOS and MacCatalyst platforms in the test host app. When developers use CollectionView or CarouselView in tests, they will now get the V2 handlers by default instead of V1 handlers.

Key Changes

  • Changed the default cv2Handlers flag from false to true for iOS/MacCatalyst test configuration
  • The environment variable override mechanism (TEST_CONFIGURATION_ARGS) remains functional for tests that need to explicitly control handler versions

@build-analysis build-analysis bot mentioned this pull request Dec 16, 2025
Open
3 tasks
@PureWeen
Copy link
Member

PureWeen commented Dec 16, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 16, 2025

Azure Pipelines successfully started running 3 pipeline(s).

PureWeen
PureWeen requested changes Dec 17, 2025
View reviewed changes
Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to update the TEST_CONFIGURATION_ARGS setting as well in the yaml files

Can you make it so that CollectionView1 is now a separate test lane and CollectionView2 is the one that runs in the normal stage?

The changes on this Pr just make it so we are only testing CollectionView2

This was referenced Dec 17, 2025
Open
Open
Open
@Ahamed-Ali
Copy link
Contributor Author

Ahamed-Ali commented Dec 17, 2025

we need to update the TEST_CONFIGURATION_ARGS setting as well in the yaml files

Can you make it so that CollectionView1 is now a separate test lane and CollectionView2 is the one that runs in the normal stage?

The changes on this Pr just make it so we are only testing CollectionView2

I have modified the TEST_CONFIGURATION_ARGS in the ui-test.yaml file so that CollectionView1/CarouselView1 run in a separate lane, and CollectionView2/CarouselView2 run in the main lane. Please let me know if you have any other concerns. @PureWeen

@build-analysis build-analysis bot mentioned this pull request Dec 17, 2025
Open
3 tasks
@PureWeen
Copy link
Member

PureWeen commented Dec 18, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 18, 2025

Azure Pipelines successfully started running 3 pipeline(s).

@sheiksyedm
Copy link
Contributor

sheiksyedm commented Dec 18, 2025

/rebase

This was referenced Dec 18, 2025
Open
Open
PureWeen
PureWeen requested changes Dec 22, 2025
View reviewed changes
Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! can you rebase and then we can merge <3

@Ahamed-Ali
Copy link
Contributor Author

Ahamed-Ali commented Dec 23, 2025

looks good! can you rebase and then we can merge <3

I have rebased it. Let me know if any other concerns @PureWeen

@build-analysis build-analysis bot mentioned this pull request Dec 23, 2025
Open
@PureWeen PureWeen changed the base branch from main to inflight/current December 30, 2025 15:44
@PureWeen PureWeen merged commit 170f27e into dotnet:inflight/current Dec 30, 2025
158 of 161 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 30, 2025
@Ahamed-Ali @PureWeen
Set the CV2 handlers as the default (#33177)
3b717f5 
<!--
!!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING
MAIN. !!!!!!!
-->

### Description of Change

To make CV2 handlers the default, set cv2handlers to true. 

(i.e) when we use **CollectionView** / **CarouselView** = >
`CollectionViewHandler2` and `CarouselViewHandler2` are used by default.

Explicitly setting CollectionView1/CarouselView1 or
CollectionView2/CarouselView2 will configure the corresponding handlers
correctly, as before.
PureWeen pushed a commit that referenced this pull request Jan 5, 2026
@Ahamed-Ali @PureWeen
Set the CV2 handlers as the default (#33177)
bb9db64 
<!--
!!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING
MAIN. !!!!!!!
-->

### Description of Change

To make CV2 handlers the default, set cv2handlers to true. 

(i.e) when we use **CollectionView** / **CarouselView** = >
`CollectionViewHandler2` and `CarouselViewHandler2` are used by default.

Explicitly setting CollectionView1/CarouselView1 or
CollectionView2/CarouselView2 will configure the corresponding handlers
correctly, as before.
@PureWeen PureWeen mentioned this pull request Jan 7, 2026
Merged
PureWeen pushed a commit that referenced this pull request Jan 9, 2026
@Ahamed-Ali @PureWeen
Set the CV2 handlers as the default (#33177)
f29c4b6 
<!--
!!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING
MAIN. !!!!!!!
-->

### Description of Change

To make CV2 handlers the default, set cv2handlers to true. 

(i.e) when we use **CollectionView** / **CarouselView** = >
`CollectionViewHandler2` and `CarouselViewHandler2` are used by default.

Explicitly setting CollectionView1/CarouselView1 or
CollectionView2/CarouselView2 will configure the corresponding handlers
correctly, as before.
PureWeen pushed a commit that referenced this pull request Jan 9, 2026
@Ahamed-Ali @PureWeen
Set the CV2 handlers as the default (#33177)
8539f5c 
<!--
!!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING
MAIN. !!!!!!!
-->

### Description of Change

To make CV2 handlers the default, set cv2handlers to true. 

(i.e) when we use **CollectionView** / **CarouselView** = >
`CollectionViewHandler2` and `CarouselViewHandler2` are used by default.

Explicitly setting CollectionView1/CarouselView1 or
CollectionView2/CarouselView2 will configure the corresponding handlers
correctly, as before.
PureWeen pushed a commit that referenced this pull request Jan 9, 2026
@Ahamed-Ali @PureWeen
Set the CV2 handlers as the default (#33177)
7ec8276 
<!--
!!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING
MAIN. !!!!!!!
-->

### Description of Change

To make CV2 handlers the default, set cv2handlers to true. 

(i.e) when we use **CollectionView** / **CarouselView** = >
`CollectionViewHandler2` and `CarouselViewHandler2` are used by default.

Explicitly setting CollectionView1/CarouselView1 or
CollectionView2/CarouselView2 will configure the corresponding handlers
correctly, as before.
PureWeen pushed a commit that referenced this pull request Jan 13, 2026
@Ahamed-Ali @PureWeen
Set the CV2 handlers as the default (#33177)
32c8d30 
<!--
!!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING
MAIN. !!!!!!!
-->

### Description of Change

To make CV2 handlers the default, set cv2handlers to true. 

(i.e) when we use **CollectionView** / **CarouselView** = >
`CollectionViewHandler2` and `CarouselViewHandler2` are used by default.

Explicitly setting CollectionView1/CarouselView1 or
CollectionView2/CarouselView2 will configure the corresponding handlers
correctly, as before.
PureWeen pushed a commit that referenced this pull request Jan 13, 2026
@Ahamed-Ali @PureWeen
Set the CV2 handlers as the default (#33177)
d1491f6 
<!--
!!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING
MAIN. !!!!!!!
-->

### Description of Change

To make CV2 handlers the default, set cv2handlers to true. 

(i.e) when we use **CollectionView** / **CarouselView** = >
`CollectionViewHandler2` and `CarouselViewHandler2` are used by default.

Explicitly setting CollectionView1/CarouselView1 or
CollectionView2/CarouselView2 will configure the corresponding handlers
correctly, as before.
PureWeen added a commit that referenced this pull request Jan 13, 2026
@PureWeen
January 5th, Candidate (#33363)
cfdbcef 
## What's Coming

.NET MAUI inflight/candidate introduces significant improvements across
all platforms with focus on quality, performance, and developer
experience. This release includes 27 commits with various improvements,
bug fixes, and enhancements.

## CollectionView
- [iOS][CV2] Fix page can be dragged down, and it would cause an extra
space between Header and EmptyView text by @devanathan-vaithiyanathan in
#31840
  <details>
  <summary>🔧 Fixes</summary>

- [I8_Header_and_Footer_Null - The page can be dragged down, and it
would cause an extra space between Header and EmptyView
text.](#31465)
  </details>

- [iOS] Fixed the Items not displayed properly in CarouselView2 by
@Ahamed-Ali in #31336
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] Items are not updated properly in
CarouselView2.](#31148)
  </details>

## Docs
- Improve Controls Core API docs by @jfversluis in
#33240

## Editor
- [iOS] Fixed an issue where an Editor with a small height inside a
ScrollView would cause the entire page to scroll by
@Tamilarasan-Paranthaman in #27948
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS][Editor] An Editor that has not enough height and resides inside
a ScrollView/CollectionView will scroll the entire
page](#27750)
  </details>

## Image
- [Android] Image control crashes on Android when image width exceeds
height by @KarthikRajaKalaimani in
#33045
  <details>
  <summary>🔧 Fixes</summary>

- [Image control crashes on Android when image width exceeds
height](#32869)
  </details>

## Mediapicker
- [Android 🤖] Add a log telling why the request is cancelled by @pictos
in #33295
  <details>
  <summary>🔧 Fixes</summary>

- [MediaPicker.PickPhotosAsync throwing TaskCancelledException in
net10-android](#33283)
  </details>

## Navigation
- [Android] Fix for App Hang When PopModalAsync Is Called Immediately
After PushModalAsync with Task.Yield() by @BagavathiPerumal in
#32479
  <details>
  <summary>🔧 Fixes</summary>

- [App hangs if PopModalAsync is called after PushModalAsync with single
await Task.Yield()](#32310)
  </details>

- [iOS 26] Navigation hangs after rapidly open and closing new page
using Navigation.PushAsync - fix by @kubaflo in
#32456
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS 26] Navigation hangs after rapidly open and closing new page
using Navigation.PushAsync](#32425)
  </details>

## Pages
- [iOS] Fix ContentPage BackgroundImageSource not working by
@Shalini-Ashokan in #33297
  <details>
  <summary>🔧 Fixes</summary>

- [.Net MAUI- Page.BackgroundImageSource not working for
iOS](#21594)
  </details>

## RadioButton
- [Issue-Resolver] Fix #33264 - RadioButtonGroup not working with
Collection View by @kubaflo in #33343
  <details>
  <summary>🔧 Fixes</summary>

- [RadioButtonGroup not working with
CollectionView](#33264)
  </details>

## SafeArea
- [Android] Fixed Label Overlapped by Android Status Bar When Using
SafeAreaEdges="Container" in .NET MAUI by @NirmalKumarYuvaraj in
#33285
  <details>
  <summary>🔧 Fixes</summary>

- [SafeAreaEdges works correctly only on the first tab in Shell. Other
tabs have content colliding with the display cutout in the landscape
mode.](#33034)
- [Label Overlapped by Android Status Bar When Using
SafeAreaEdges="Container" in .NET
MAUI](#32941)
- [[MAUI 10] Layout breaks on first navigation (Shell // route) until
soft keyboard appears/disappears (Android +
iOS)](#33038)
  </details>

## ScrollView
- [Windows, Android] Fix ScrollView Content Not Removed When Set to Null
by @devanathan-vaithiyanathan in
#33069
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows, Android] ScrollView Content Not Removed When Set to
Null](#33067)
  </details>

## Searchbar
- Fix Android crash when changing shared Drawable tint on Searchbar by
@tritter in #33071
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] Crash on changing Tint of
Searchbar](#33070)
  </details>

## Shell
- [iOS] - Fix Custom FlyoutIcon from Being Overridden to Default Color
in Shell by @prakashKannanSf3972 in
#27580
  <details>
  <summary>🔧 Fixes</summary>

- [Change the flyout icon
color](#6738)
  </details>

- [iOS] Fix Shell NavBarIsVisible updates when switching ShellContent by
@Vignesh-SF3580 in #33195
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] Shell NavBarIsVisible is not updated when changing
ShellContent](#33191)
  </details>

## Slider
- [C] Fix Slider and Stepper property order independence by
@StephaneDelcroix in #32939
  <details>
  <summary>🔧 Fixes</summary>

- [Slider Binding Initialization Order Causes Incorrect Value Assignment
in XAML](#32903)
- [Slider is very broken, Value is a mess when setting
Minimum](#14472)
- [Slider is buggy depending on order of
properties](#18910)
- [Stepper Value is incorrectly clamped to default min/max when using
bindableproperties in MVVM
pattern](#12243)
- [[Issue-Resolver] Fix #32903 - Sliderbinding initialization order
issue](#32907)
  </details>

## Stepper
- [Windows] Maui Stepper: Clamp minimum and maximum value by @OomJan in
#33275
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows] Maui Stepper is not clamped to minimum or maximum
internally](#33274)
  </details>

- [iOS] Fixed the UIStepper Value from being clamped based on old higher
MinimumValue - Candidate PR test failure fix- 33363 by @Ahamed-Ali in
#33392

## TabbedPage
- [windows] Fixed Rapid change of selected tab results in crash. by
@praveenkumarkarunanithi in #33113
  <details>
  <summary>🔧 Fixes</summary>

- [Rapid change of selected tab results in crash on
Windows.](#32824)
  </details>

## Titlebar
- [Mac] Fix TitleBar Content Overlapping with Traffic Light Buttons on
Latest macOS Version by @devanathan-vaithiyanathan in
#33157
  <details>
  <summary>🔧 Fixes</summary>

- [TitleBar Content Overlapping with Traffic Light Buttons on Latest
macOS Version](#33136)
  </details>

## Xaml
- Fix for Control does not update from binding anymore after
MultiBinding.ConvertBack is called by @BagavathiPerumal in
#33128
  <details>
  <summary>🔧 Fixes</summary>

- [Control does not update from binding anymore after
MultiBinding.ConvertBack is
called](#24969)
- [The issue with the MultiBinding converter with two way binding mode
does not work properly when changing the
values.](#20382)
  </details>


<details>
<summary>🔧 Infrastructure (1)</summary>

- Avoid KVO on CALayer by introducing an Apple PlatformInterop by
@albyrock87 in #30861

</details>

<details>
<summary>🧪 Testing (2)</summary>

- [Testing] Enable UITest Issue18193 on MacCatalyst by @NafeelaNazhir in
#31653
  <details>
  <summary>🔧 Fixes</summary>

- [Test Issue18193 was disabled on Mac
Catalyst](#27206)
  </details>
- Set the CV2 handlers as the default by @Ahamed-Ali in
#33177

</details>

<details>
<summary>📦 Other (3)</summary>

- Update WindowsAppSDK to 1.8 by @mattleibow in
#32174
  <details>
  <summary>🔧 Fixes</summary>

- [Update to WindowsAppSDK](#30858)
  </details>
- Fix command dependency reentrancy by @simonrozsival in
#33129
- Fix SafeArea AdjustPan handling and add AdjustNothing mode tests by
@PureWeen via @Copilot in #33354

</details>
**Full Changelog**:
main...inflight/candidate
kubaflo pushed a commit to kubaflo/maui that referenced this pull request Jan 16, 2026
@Ahamed-Ali @kubaflo
Set the CV2 handlers as the default (dotnet#33177)
87337cd 
<!--
!!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING
MAIN. !!!!!!!
-->

### Description of Change

To make CV2 handlers the default, set cv2handlers to true. 

(i.e) when we use **CollectionView** / **CarouselView** = >
`CollectionViewHandler2` and `CarouselViewHandler2` are used by default.

Explicitly setting CollectionView1/CarouselView1 or
CollectionView2/CarouselView2 will configure the corresponding handlers
correctly, as before.
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@PureWeen PureWeen PureWeen approved these changes

@kubaflo kubaflo kubaflo approved these changes

Assignees

No one assigned

Labels

area-testing Unit tests, device tests community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Ahamed-Ali @PureWeen @sheiksyedm @kubaflo