Fix command dependency reentrancy#33129
Merged
PureWeen merged 2 commits intoinflight/currentfrom Jan 2, 2026
Merged
Conversation
3 tasks
Member
Key FindingsPurpose: Fixes a re-entrancy/feedback loop issue in command dependency evaluation that caused hangs when CommandParameter is frequently updated (e.g., via MultiBinding). The Fix: Adds guards to prevent unnecessary forced binding reapplication - only forces when binding is truly pending (bound but still null). Concerns Identified:
Test Migration: Also migrates two NUnit tests to xUnit (correct implementation). Verdict: Code logic is sound and solves the reported issue, but there's a potential edge case that should be tested. The reviewer is asking if you'd like them to proceed with validation (running tests, adding edge case tests). |
StephaneDelcroix
previously approved these changes
Dec 15, 2025
PureWeen
force-pushed
the
inflight/current
branch
from
0ebe826 to
9f61d47
Compare
github-actions
bot
force-pushed
the
inflight/current
branch
from
eb56aa1 to
e7ce2dd
Compare
Member
|
/rebase |
PureWeen
force-pushed
the
inflight/current
branch
2 times, most recently
from
31bad8b to
79921f3
Compare
PureWeen
force-pushed
the
inflight/current
branch
from
eb69010 to
2bfec9b
Compare
Member
|
/rebase |
github-actions
bot
force-pushed
the
inflight/current
branch
from
170f27e to
3b717f5
Compare
simonrozsival
force-pushed
the
dev/srozsival/fix-infinite-recursion
branch
from
c1c9fbe to
67f8d3b
Compare
- Add BindableProperty dependency mechanism via DependsOn() method - Add ForceBindingApply() to force binding application before CanExecute - Register Command -> CommandParameter dependency in Button, CheckBox, SearchBar, MenuItem, RefreshView, TextCell - Add unit tests for template binding and reparenting scenarios - Converted tests to xUnit format
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
3 tasks
PureWeen
approved these changes
Jan 2, 2026
PureWeen
added a commit
that referenced
this pull request
Jan 5, 2026
### What Prevents a re-entrant/feedback-loop scenario during CanExecute evaluation where forcing dependency bindings to apply (e.g., CommandParameter) can recursively trigger further CanExecute refreshes and lead to hangs. ### Why GetCanExecute currently forces binding application for dependent properties on every evaluation. In scenarios involving frequent command refresh (e.g., MultiBinding-driven CommandParameter updates), this can cause repeated binding reapplication and re-entrant CanExecute calls. ### How Only force dependency binding application when it appears pending: - dependency is bound - dependency value is currently null This keeps the original dependency ordering intent while avoiding unnecessary re-application. ### Tests - dotnet test ./src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj - dotnet test ./src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj --blame-hang --blame-hang-timeout 10s --filter FullyQualifiedName~Maui18123 --------- Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
PureWeen
added a commit
that referenced
this pull request
Jan 9, 2026
### What Prevents a re-entrant/feedback-loop scenario during CanExecute evaluation where forcing dependency bindings to apply (e.g., CommandParameter) can recursively trigger further CanExecute refreshes and lead to hangs. ### Why GetCanExecute currently forces binding application for dependent properties on every evaluation. In scenarios involving frequent command refresh (e.g., MultiBinding-driven CommandParameter updates), this can cause repeated binding reapplication and re-entrant CanExecute calls. ### How Only force dependency binding application when it appears pending: - dependency is bound - dependency value is currently null This keeps the original dependency ordering intent while avoiding unnecessary re-application. ### Tests - dotnet test ./src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj - dotnet test ./src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj --blame-hang --blame-hang-timeout 10s --filter FullyQualifiedName~Maui18123 --------- Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
PureWeen
added a commit
that referenced
this pull request
Jan 9, 2026
### What Prevents a re-entrant/feedback-loop scenario during CanExecute evaluation where forcing dependency bindings to apply (e.g., CommandParameter) can recursively trigger further CanExecute refreshes and lead to hangs. ### Why GetCanExecute currently forces binding application for dependent properties on every evaluation. In scenarios involving frequent command refresh (e.g., MultiBinding-driven CommandParameter updates), this can cause repeated binding reapplication and re-entrant CanExecute calls. ### How Only force dependency binding application when it appears pending: - dependency is bound - dependency value is currently null This keeps the original dependency ordering intent while avoiding unnecessary re-application. ### Tests - dotnet test ./src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj - dotnet test ./src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj --blame-hang --blame-hang-timeout 10s --filter FullyQualifiedName~Maui18123 --------- Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
PureWeen
added a commit
that referenced
this pull request
Jan 9, 2026
### What Prevents a re-entrant/feedback-loop scenario during CanExecute evaluation where forcing dependency bindings to apply (e.g., CommandParameter) can recursively trigger further CanExecute refreshes and lead to hangs. ### Why GetCanExecute currently forces binding application for dependent properties on every evaluation. In scenarios involving frequent command refresh (e.g., MultiBinding-driven CommandParameter updates), this can cause repeated binding reapplication and re-entrant CanExecute calls. ### How Only force dependency binding application when it appears pending: - dependency is bound - dependency value is currently null This keeps the original dependency ordering intent while avoiding unnecessary re-application. ### Tests - dotnet test ./src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj - dotnet test ./src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj --blame-hang --blame-hang-timeout 10s --filter FullyQualifiedName~Maui18123 --------- Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
PureWeen
added a commit
that referenced
this pull request
Jan 13, 2026
### What Prevents a re-entrant/feedback-loop scenario during CanExecute evaluation where forcing dependency bindings to apply (e.g., CommandParameter) can recursively trigger further CanExecute refreshes and lead to hangs. ### Why GetCanExecute currently forces binding application for dependent properties on every evaluation. In scenarios involving frequent command refresh (e.g., MultiBinding-driven CommandParameter updates), this can cause repeated binding reapplication and re-entrant CanExecute calls. ### How Only force dependency binding application when it appears pending: - dependency is bound - dependency value is currently null This keeps the original dependency ordering intent while avoiding unnecessary re-application. ### Tests - dotnet test ./src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj - dotnet test ./src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj --blame-hang --blame-hang-timeout 10s --filter FullyQualifiedName~Maui18123 --------- Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
PureWeen
added a commit
that referenced
this pull request
Jan 13, 2026
### What Prevents a re-entrant/feedback-loop scenario during CanExecute evaluation where forcing dependency bindings to apply (e.g., CommandParameter) can recursively trigger further CanExecute refreshes and lead to hangs. ### Why GetCanExecute currently forces binding application for dependent properties on every evaluation. In scenarios involving frequent command refresh (e.g., MultiBinding-driven CommandParameter updates), this can cause repeated binding reapplication and re-entrant CanExecute calls. ### How Only force dependency binding application when it appears pending: - dependency is bound - dependency value is currently null This keeps the original dependency ordering intent while avoiding unnecessary re-application. ### Tests - dotnet test ./src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj - dotnet test ./src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj --blame-hang --blame-hang-timeout 10s --filter FullyQualifiedName~Maui18123 --------- Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
PureWeen
added a commit
that referenced
this pull request
Jan 13, 2026
## What's Coming .NET MAUI inflight/candidate introduces significant improvements across all platforms with focus on quality, performance, and developer experience. This release includes 27 commits with various improvements, bug fixes, and enhancements. ## CollectionView - [iOS][CV2] Fix page can be dragged down, and it would cause an extra space between Header and EmptyView text by @devanathan-vaithiyanathan in #31840 <details> <summary>🔧 Fixes</summary> - [I8_Header_and_Footer_Null - The page can be dragged down, and it would cause an extra space between Header and EmptyView text.](#31465) </details> - [iOS] Fixed the Items not displayed properly in CarouselView2 by @Ahamed-Ali in #31336 <details> <summary>🔧 Fixes</summary> - [[iOS] Items are not updated properly in CarouselView2.](#31148) </details> ## Docs - Improve Controls Core API docs by @jfversluis in #33240 ## Editor - [iOS] Fixed an issue where an Editor with a small height inside a ScrollView would cause the entire page to scroll by @Tamilarasan-Paranthaman in #27948 <details> <summary>🔧 Fixes</summary> - [[iOS][Editor] An Editor that has not enough height and resides inside a ScrollView/CollectionView will scroll the entire page](#27750) </details> ## Image - [Android] Image control crashes on Android when image width exceeds height by @KarthikRajaKalaimani in #33045 <details> <summary>🔧 Fixes</summary> - [Image control crashes on Android when image width exceeds height](#32869) </details> ## Mediapicker - [Android 🤖] Add a log telling why the request is cancelled by @pictos in #33295 <details> <summary>🔧 Fixes</summary> - [MediaPicker.PickPhotosAsync throwing TaskCancelledException in net10-android](#33283) </details> ## Navigation - [Android] Fix for App Hang When PopModalAsync Is Called Immediately After PushModalAsync with Task.Yield() by @BagavathiPerumal in #32479 <details> <summary>🔧 Fixes</summary> - [App hangs if PopModalAsync is called after PushModalAsync with single await Task.Yield()](#32310) </details> - [iOS 26] Navigation hangs after rapidly open and closing new page using Navigation.PushAsync - fix by @kubaflo in #32456 <details> <summary>🔧 Fixes</summary> - [[iOS 26] Navigation hangs after rapidly open and closing new page using Navigation.PushAsync](#32425) </details> ## Pages - [iOS] Fix ContentPage BackgroundImageSource not working by @Shalini-Ashokan in #33297 <details> <summary>🔧 Fixes</summary> - [.Net MAUI- Page.BackgroundImageSource not working for iOS](#21594) </details> ## RadioButton - [Issue-Resolver] Fix #33264 - RadioButtonGroup not working with Collection View by @kubaflo in #33343 <details> <summary>🔧 Fixes</summary> - [RadioButtonGroup not working with CollectionView](#33264) </details> ## SafeArea - [Android] Fixed Label Overlapped by Android Status Bar When Using SafeAreaEdges="Container" in .NET MAUI by @NirmalKumarYuvaraj in #33285 <details> <summary>🔧 Fixes</summary> - [SafeAreaEdges works correctly only on the first tab in Shell. Other tabs have content colliding with the display cutout in the landscape mode.](#33034) - [Label Overlapped by Android Status Bar When Using SafeAreaEdges="Container" in .NET MAUI](#32941) - [[MAUI 10] Layout breaks on first navigation (Shell // route) until soft keyboard appears/disappears (Android + iOS)](#33038) </details> ## ScrollView - [Windows, Android] Fix ScrollView Content Not Removed When Set to Null by @devanathan-vaithiyanathan in #33069 <details> <summary>🔧 Fixes</summary> - [[Windows, Android] ScrollView Content Not Removed When Set to Null](#33067) </details> ## Searchbar - Fix Android crash when changing shared Drawable tint on Searchbar by @tritter in #33071 <details> <summary>🔧 Fixes</summary> - [[Android] Crash on changing Tint of Searchbar](#33070) </details> ## Shell - [iOS] - Fix Custom FlyoutIcon from Being Overridden to Default Color in Shell by @prakashKannanSf3972 in #27580 <details> <summary>🔧 Fixes</summary> - [Change the flyout icon color](#6738) </details> - [iOS] Fix Shell NavBarIsVisible updates when switching ShellContent by @Vignesh-SF3580 in #33195 <details> <summary>🔧 Fixes</summary> - [[iOS] Shell NavBarIsVisible is not updated when changing ShellContent](#33191) </details> ## Slider - [C] Fix Slider and Stepper property order independence by @StephaneDelcroix in #32939 <details> <summary>🔧 Fixes</summary> - [Slider Binding Initialization Order Causes Incorrect Value Assignment in XAML](#32903) - [Slider is very broken, Value is a mess when setting Minimum](#14472) - [Slider is buggy depending on order of properties](#18910) - [Stepper Value is incorrectly clamped to default min/max when using bindableproperties in MVVM pattern](#12243) - [[Issue-Resolver] Fix #32903 - Sliderbinding initialization order issue](#32907) </details> ## Stepper - [Windows] Maui Stepper: Clamp minimum and maximum value by @OomJan in #33275 <details> <summary>🔧 Fixes</summary> - [[Windows] Maui Stepper is not clamped to minimum or maximum internally](#33274) </details> - [iOS] Fixed the UIStepper Value from being clamped based on old higher MinimumValue - Candidate PR test failure fix- 33363 by @Ahamed-Ali in #33392 ## TabbedPage - [windows] Fixed Rapid change of selected tab results in crash. by @praveenkumarkarunanithi in #33113 <details> <summary>🔧 Fixes</summary> - [Rapid change of selected tab results in crash on Windows.](#32824) </details> ## Titlebar - [Mac] Fix TitleBar Content Overlapping with Traffic Light Buttons on Latest macOS Version by @devanathan-vaithiyanathan in #33157 <details> <summary>🔧 Fixes</summary> - [TitleBar Content Overlapping with Traffic Light Buttons on Latest macOS Version](#33136) </details> ## Xaml - Fix for Control does not update from binding anymore after MultiBinding.ConvertBack is called by @BagavathiPerumal in #33128 <details> <summary>🔧 Fixes</summary> - [Control does not update from binding anymore after MultiBinding.ConvertBack is called](#24969) - [The issue with the MultiBinding converter with two way binding mode does not work properly when changing the values.](#20382) </details> <details> <summary>🔧 Infrastructure (1)</summary> - Avoid KVO on CALayer by introducing an Apple PlatformInterop by @albyrock87 in #30861 </details> <details> <summary>🧪 Testing (2)</summary> - [Testing] Enable UITest Issue18193 on MacCatalyst by @NafeelaNazhir in #31653 <details> <summary>🔧 Fixes</summary> - [Test Issue18193 was disabled on Mac Catalyst](#27206) </details> - Set the CV2 handlers as the default by @Ahamed-Ali in #33177 </details> <details> <summary>📦 Other (3)</summary> - Update WindowsAppSDK to 1.8 by @mattleibow in #32174 <details> <summary>🔧 Fixes</summary> - [Update to WindowsAppSDK](#30858) </details> - Fix command dependency reentrancy by @simonrozsival in #33129 - Fix SafeArea AdjustPan handling and add AdjustNothing mode tests by @PureWeen via @Copilot in #33354 </details> **Full Changelog**: main...inflight/candidate
kubaflo
pushed a commit
to kubaflo/maui
that referenced
this pull request
Jan 16, 2026
### What Prevents a re-entrant/feedback-loop scenario during CanExecute evaluation where forcing dependency bindings to apply (e.g., CommandParameter) can recursively trigger further CanExecute refreshes and lead to hangs. ### Why GetCanExecute currently forces binding application for dependent properties on every evaluation. In scenarios involving frequent command refresh (e.g., MultiBinding-driven CommandParameter updates), this can cause repeated binding reapplication and re-entrant CanExecute calls. ### How Only force dependency binding application when it appears pending: - dependency is bound - dependency value is currently null This keeps the original dependency ordering intent while avoiding unnecessary re-application. ### Tests - dotnet test ./src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj - dotnet test ./src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj --blame-hang --blame-hang-timeout 10s --filter FullyQualifiedName~Maui18123 --------- Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Prevents a re-entrant/feedback-loop scenario during CanExecute evaluation where forcing dependency bindings to apply (e.g., CommandParameter) can recursively trigger further CanExecute refreshes and lead to hangs.
Why
GetCanExecute currently forces binding application for dependent properties on every evaluation. In scenarios involving frequent command refresh (e.g., MultiBinding-driven CommandParameter updates), this can cause repeated binding reapplication and re-entrant CanExecute calls.
How
Only force dependency binding application when it appears pending:
This keeps the original dependency ordering intent while avoiding unnecessary re-application.
Tests