-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Mac] Fix TitleBar Content Overlapping with Traffic Light Buttons on Latest macOS Version #33157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jfversluis
merged 5 commits into
dotnet:inflight/current
from
devanathan-vaithiyanathan:fix-33136
Dec 19, 2025
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7434058
fix added
devanathan-vaithiyanathan 74fe389
Update Issue33136.cs
devanathan-vaithiyanathan a39b7dc
snapshot added
devanathan-vaithiyanathan eb73f3a
Fix modified
devanathan-vaithiyanathan 5a57f2b
Fix formatting issues in test files
StephaneDelcroix File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| namespace Maui.Controls.Sample.Issues; | ||
|
|
||
| [Issue(IssueTracker.Github, 33136, "TitleBar Content Overlapping with Traffic Light Buttons on Latest macOS Version", PlatformAffected.macOS)] | ||
| public class Issue33136 : ContentPage | ||
| { | ||
| public Issue33136() | ||
| { | ||
| // Create TitleBar | ||
| var titleBar = new TitleBar | ||
| { | ||
| Title = "Maui App", | ||
| Subtitle = "Hello, World!", | ||
| ForegroundColor = Colors.Red, | ||
| HeightRequest = 48 | ||
| }; | ||
|
|
||
| titleBar.LeadingContent = new Image { Source = "dotnet_bot.png", HeightRequest = 24 }; | ||
|
|
||
| // Set the TitleBar on the current Window when this page appears | ||
| this.Loaded += (sender, e) => | ||
| { | ||
| if (Window != null) | ||
| { | ||
| Window.TitleBar = titleBar; | ||
| } | ||
| }; | ||
|
|
||
| // Create the page content with a Label | ||
| Content = new VerticalStackLayout | ||
| { | ||
| Spacing = 25, | ||
| Padding = new Thickness(30), | ||
| VerticalOptions = LayoutOptions.Center, | ||
| Children = | ||
| { | ||
| new Label | ||
| { | ||
| Text = "TitleBar should be aligned properly", | ||
| AutomationId = "TitleBarAlignmentLabel", | ||
| FontSize = 32, | ||
| HorizontalOptions = LayoutOptions.Center | ||
| }, | ||
| } | ||
| }; | ||
| } | ||
| } |
Binary file added
BIN
+22.8 KB
src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/VerifyTitleBarAlignment.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
22 changes: 22 additions & 0 deletions
22
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue33136.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| #if TEST_FAILS_ON_ANDROID && TEST_FAILS_ON_IOS // TitleBar is only applicable for Windows and macOS | ||
| using NUnit.Framework; | ||
| using UITest.Appium; | ||
| using UITest.Core; | ||
|
|
||
| namespace Microsoft.Maui.TestCases.Tests.Issues; | ||
|
|
||
| public class Issue33136 : _IssuesUITest | ||
| { | ||
| public Issue33136(TestDevice device) : base(device) { } | ||
|
|
||
| public override string Issue => "TitleBar Content Overlapping with Traffic Light Buttons on Latest macOS Version"; | ||
|
|
||
| [Test] | ||
| [Category(UITestCategories.Window)] | ||
| public void VerifyTitleBarAlignment() | ||
| { | ||
| App.WaitForElement("TitleBarAlignmentLabel"); | ||
| VerifyScreenshot(includeTitleBar: true); | ||
| } | ||
| } | ||
| #endif |
Binary file added
BIN
+12.6 KB
...trols/tests/TestCases.WinUI.Tests/snapshots/windows/VerifyTitleBarAlignment.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.