Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use win10-* for the RIDs #3185

Merged
merged 3 commits into from
Oct 29, 2021
Merged

Use win10-* for the RIDs #3185

merged 3 commits into from
Oct 29, 2021

Conversation

mattleibow
Copy link
Member

@mattleibow mattleibow commented Oct 29, 2021

Description of Change

Use the win10-* for the RIDs to match what the Windows App SDK is doing,

The win-x64 RID means it could potentially run on Windows 7, which is not possible. Moving to win10 makes the app give a launch error. But not only that, we need to do this because the WASDK is using win10.

This can also be seen in the #3172 PR where it is required so we get the native files.

Additions made

  • Updates the RID in the templates to win10-x64

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might affect accessibility?

  • Does this PR introduce a new control? (If yes, add an example using SemanticProperties to the SemanticsPage)
  • APIs that modify focusability?
  • APIs that modify any text property on a control?
  • Does this PR modify view nesting or view arrangement in anyway?
  • Is there the smallest possibility that your PR will change accessibility?
  • I'm not sure, please help me

If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.

@mattleibow mattleibow added the area-templates Project templates, Item Templates for Blazor and MAUI label Oct 29, 2021
@mattleibow mattleibow requested a review from Redth October 29, 2021 11:52
@mattleibow mattleibow requested a review from Eilon as a code owner October 29, 2021 11:52
@mattleibow mattleibow enabled auto-merge (squash) October 29, 2021 13:41
Copy link
Member

@Eilon Eilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit. If it doesn't work on less than win10, no reason to pretend, right?

@mattleibow mattleibow merged commit feb65de into main Oct 29, 2021
@mattleibow mattleibow deleted the dev/win10 branch October 29, 2021 18:07
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@samhouts samhouts added the fixed-in-6.0.101-preview.11.3 Look for this fix in 6.0.101-preview.11.3! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-templates Project templates, Item Templates for Blazor and MAUI fixed-in-6.0.101-preview.11.3 Look for this fix in 6.0.101-preview.11.3!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants