Set up for unpackaged app projects #3172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dev/unpackaged # Conflicts: # Directory.Build.targets # src/Workload/Microsoft.Maui.Sdk/Sdk/WinUI.SingleProject.targets
mattleibow
commented
Oct 28, 2021
| <RuntimeIdentifier>win-x64</RuntimeIdentifier> | ||
| <RuntimeIdentifier>win10-x64</RuntimeIdentifier> |
There was a problem hiding this comment.
This is a gotcha since we pretend support winui on win7, but since we don't, we should probably update all the things to be win10-x64.
| .UseVersionTracking() | ||
| //.UseVersionTracking() |
There was a problem hiding this comment.
This uses preferences which assumes packaged projects.
Eilon
requested changes
Oct 29, 2021
| string root; | ||
| try | ||
| { | ||
| root = global::Windows.ApplicationModel.Package.Current.InstalledLocation.Path; |
There was a problem hiding this comment.
Is there a non-exceptional way to do this? Otherwise unpackaged apps will all get exceptions on startup?
| { | ||
| try | ||
| { | ||
| return Package.Current.Id.Name; |
There was a problem hiding this comment.
See earlier comment about exceptions. This doesn't look so nice
Eilon
added
the
legacy-area-desktop
|
This is totes hax! Needs a real fix in here. Probably not even this PR. Let me close to avoid confusion. |
Eilon
added
the
t/desktop
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
nuff said!