[iOS] Flyout Menu CollectionView First Item Misaligned - fix #30501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the misalignment of the first item in the iOS Shell flyout by removing the legacy SetHeaderContentInset logic and consolidating header offset calculations.
- Remove all calls to
SetHeaderContentInsetand delete the method implementation - Simplify header offset logic in
LayoutContentto always use the header’s frame height - Drop obsolete call in
ViewSafeAreaInsetsDidChange
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellTableViewController.cs | Removed the SetHeaderContentInset call in safe-area changes |
| src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellFlyoutLayoutManager.cs | Deleted SetHeaderContentInset method and calls; simplified the header offset logic |
Comments suppressed due to low confidence (2)
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellFlyoutLayoutManager.cs:191
- This layout change affects the iOS flyout header and first-item alignment; consider adding corresponding UI tests in TestCases.HostApp and TestCases.Shared.Tests to verify correct positioning under both scrollable and non-scrollable scenarios.
internal void UpdateHeaderSize()
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellFlyoutLayoutManager.cs:289
- By removing the conditional branch for ScrollView, the offset now always uses the header height instead of margin for scrollable content. Please verify that this doesn't reintroduce layout issues in scrollable scenarios, or restore a margin-based offset path if needed.
contentYOffset += HeaderView.Frame.Height;
kubaflo
added
platform/ios
area-controls-collectionview
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
github-actions
bot
force-pushed
the
fix-30483
branch
from
5c96df0 to
2fac333
Compare
|
Thanks @kubaflo, this makes sense! |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
added
the
p/0
|
@kubaflo can you add a test for this? |
|
I've added a test |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
mattleibow
previously approved these changes
Sep 1, 2025
github-project-automation
bot
moved this from Ready To Review
to Approved
in MAUI SDK Ongoing
sheiksyedm
added a commit
to sheiksyedm/maui
that referenced
this pull request
Sep 17, 2025
Merged
This was referenced Oct 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REVERTED
Description of Change
The regression is caused by this PR: #28670, but I think that the changes introduced by @albyrock87 let us simplify the code and easily fix the regression
Issues Fixed
Fixes #30483
Screen.Recording.2025-07-09.at.02.08.10.mov
Screen.Recording.2025-07-09.at.02.07.27.mov