Skip to content

[Copilot] Extract enhanced copilot instructions from PR 30020 #30333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 3 commits into from
Closed

[Copilot] Extract enhanced copilot instructions from PR 30020 #30333

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81a3b25
Initial plan
Copilot Jun 30, 2025
dc29f2d
Add enhanced copilot instructions from PR 30020
Copilot Jun 30, 2025
305ed3e
Revert changes to cgmanifest.json and templatestrings.json restrictio…
Copilot Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions .github/copilot-instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,13 +102,19 @@ dotnet cake --target=dotnet-pack
### Testing and Debugging

#### Testing Guidelines
- **Always** ensure code compiles before running tests to validate changes, otherwise you might be running tests against old code
- **Always** run unit tests for any code changes before finishing
- **Never** leave failing unit tests that were introduced by your changes
- Add tests for new functionality
- Ensure existing tests pass:
- `src/Core/tests/UnitTests/Core.UnitTests.csproj`
- `src/Essentials/test/UnitTests/Essentials.UnitTests.csproj`
- `src/Compatibility/Core/tests/Compatibility.UnitTests/Compatibility.Core.UnitTests.csproj`
- `src/Controls/tests/Core.UnitTests/Controls.Core.UnitTests.csproj`
- `src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj`
- Use `dotnet test` to run specific test projects or test filters
- When adding new unit tests, ensure they pass consistently
- Fix any test failures before committing and pushing changes

### Code Formatting

Expand Down Expand Up @@ -174,10 +180,24 @@ When working on an issue:
- More robust implementation patterns

### Files to Never Commit
- **Never** check in changes to `cgmanifest.json` files
- **Never** check in changes to `templatestrings.json` files
- **Never** check in changes to `cgmanifest.json` files (especially in `Templates/src/` directory)
- **Never** check in changes to `templatestrings.json` files (especially in `Templates/src/` directory)
- **Always revert** any changes to JSON files in the `Templates/src/` directory before committing

@PureWeen PureWeen Jun 30, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert the changes to these lines

Copilot AI Jun 30, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted the changes to lines 183-185 as requested. The enhanced cgmanifest.json and templatestrings.json restrictions have been removed and the file is back to its original state. (46c8d84)

- These files are automatically generated and should not be modified manually


### Platform-Specific Restrictions
- **Never** make changes to files related to Tizen platform
- Tizen-specific code should not be modified unless explicitly required for critical fixes

### Testing Guidelines
- **Always** ensure code compiles before running tests to validate changes, otherwise you might be running tests against old code
- **Always** run unit tests for any code changes before finishing
- **Never** leave failing unit tests that were introduced by your changes
- Use `dotnet test` to run specific test projects or test filters
- When adding new unit tests, ensure they pass consistently
- Fix any test failures before committing and pushing changes

### File Reset Guidelines for AI Agents
Since coding agents function as both CI and pair programmers, they need to handle CI-generated files appropriately:

Expand Down