Skip to content

[Copilot] Extract enhanced copilot instructions from PR 30020#30333

Closed
Copilot wants to merge 3 commits into
mainfrom
copilot/fix-30332
Closed

[Copilot] Extract enhanced copilot instructions from PR 30020#30333
Copilot wants to merge 3 commits into
mainfrom
copilot/fix-30332

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jun 30, 2025

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

This PR extracts just the GitHub Copilot instructions improvements from PR #30020, creating a focused update to our development guidelines without the Grid layout feature changes.

Changes Applied

Enhanced Testing Guidelines

  • Added emphasis on ensuring code compiles before running tests to avoid testing against stale code
  • Added requirement to run unit tests for any code changes before finishing work
  • Added prohibition against leaving failing unit tests introduced by changes
  • Added guidance on using dotnet test with specific test projects or filters
  • Added requirement for consistent test execution and fixing any test failures before committing

Improved File Commit Restrictions

  • Enhanced cgmanifest.json and templatestrings.json restrictions with specific emphasis on the Templates/src/ directory
  • Added explicit requirement to revert changes to JSON files in the Templates/src/ directory before committing
  • Clarified that these files are automatically generated and should not be manually modified

Platform-Specific Restrictions

  • Added restrictions against modifying Tizen platform-related files
  • Clarified that Tizen-specific code should only be modified when explicitly required for critical fixes

These improvements enhance the development workflow guidance for GitHub Copilot agents and human developers working on the .NET MAUI repository, ensuring better code quality and reducing common mistakes in the development process.

Fixes #30332.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>
Copilot AI changed the title [WIP] [Copilot] Create a PR with just the copilot instructions from PR 30020 [Copilot] Extract enhanced copilot instructions from PR 30020 Jun 30, 2025
Copilot AI requested a review from PureWeen June 30, 2025 16:37
Comment thread .github/copilot-instructions.md Outdated
Comment on lines +183 to +185
- **Never** check in changes to `cgmanifest.json` files (especially in `Templates/src/` directory)
- **Never** check in changes to `templatestrings.json` files (especially in `Templates/src/` directory)
- **Always revert** any changes to JSON files in the `Templates/src/` directory before committing
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert the changes to these lines

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted the changes to lines 183-185 as requested. The enhanced cgmanifest.json and templatestrings.json restrictions have been removed and the file is back to its original state. (46c8d84)

…ns as requested

Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>
Copilot AI requested a review from PureWeen June 30, 2025 17:19
@PureWeen PureWeen marked this pull request as ready for review June 30, 2025 20:54
@PureWeen PureWeen closed this Jul 2, 2025
@PureWeen PureWeen deleted the copilot/fix-30332 branch July 6, 2025 22:24
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Copilot] Create a PR with just the copilot instructions from PR 30020

2 participants