Adopt DensityValue in Grid to Enable Precise Pixel-Aware Layout

.github/copilot-instructions.md

@@ -102,13 +102,19 @@ dotnet cake --target=dotnet-pack
 ### Testing and Debugging
 
 #### Testing Guidelines
+- **Always** ensure code compiles before running tests to validate changes, otherwise you might be running tests against old code
+- **Always** run unit tests for any code changes before finishing
+- **Never** leave failing unit tests that were introduced by your changes
 - Add tests for new functionality
 - Ensure existing tests pass:
   - `src/Core/tests/UnitTests/Core.UnitTests.csproj`
   - `src/Essentials/test/UnitTests/Essentials.UnitTests.csproj`
   - `src/Compatibility/Core/tests/Compatibility.UnitTests/Compatibility.Core.UnitTests.csproj`
   - `src/Controls/tests/Core.UnitTests/Controls.Core.UnitTests.csproj`
   - `src/Controls/tests/Xaml.UnitTests/Controls.Xaml.UnitTests.csproj`
+- Use `dotnet test` to run specific test projects or test filters
+- When adding new unit tests, ensure they pass consistently
+- Fix any test failures before committing and pushing changes
 
 ### Code Formatting
 
@@ -174,10 +180,25 @@ When working on an issue:
    - More robust implementation patterns
 
 ### Files to Never Commit
-- **Never** check in changes to `cgmanifest.json` files
-- **Never** check in changes to `templatestrings.json` files
+- **Never** check in changes to `cgmanifest.json` files (especially in `Templates/src/` directory)
+- **Never** check in changes to `templatestrings.json` files (especially in `Templates/src/` directory)
+- **Always revert** any changes to JSON files in the `Templates/src/` directory before committing
 - These files are automatically generated and should not be modified manually
 
+
+
+### Platform-Specific Restrictions
+- **Never** make changes to files related to Tizen platform
+- Tizen-specific code should not be modified unless explicitly required for critical fixes
+
+### Testing Guidelines
+- **Always** ensure code compiles before running tests to validate changes, otherwise you might be running tests against old code
+- **Always** run unit tests for any code changes before finishing
+- **Never** leave failing unit tests that were introduced by your changes
+- Use `dotnet test` to run specific test projects or test filters
+- When adding new unit tests, ensure they pass consistently
+- Fix any test failures before committing and pushing changes
+
 ### File Reset Guidelines for AI Agents
 Since coding agents function as both CI and pair programmers, they need to handle CI-generated files appropriately:
 

src/Controls/src/Core/View/View.cs

@@ -17,7 +17,7 @@ namespace Microsoft.Maui.Controls
 	/// This is the base class for <see cref="Layout"/> and most of the controls.
 	/// Because <see cref="View" /> ultimately inherits from <see cref="BindableObject" />, application developers can use the Model-View-ViewModel architecture, as well as XAML, to develop portable user interfaces.
 	/// </remarks>
-	public partial class View : VisualElement, IViewController, IGestureController, IGestureRecognizers, IView, IPropertyMapperView, IHotReloadableView, IControlsView
+	public partial class View : VisualElement, IViewController, IGestureController, IGestureRecognizers, IView, IPropertyMapperView, IHotReloadableView, IControlsView, IViewWithWindow
 	{
 		protected internal IGestureController GestureController => this;
 
@@ -314,6 +314,8 @@ internal protected PropertyMapper<T> GetRendererOverrides<T>() where T : IView =
 
 		IReloadHandler IHotReloadableView.ReloadHandler { get; set; }
 
+		IWindow? IViewWithWindow.Window => Window;
+
 		void IHotReloadableView.TransferState(IView newView)
 		{
 			//TODO: LEt you hot reload the the ViewModel

src/Controls/tests/DeviceTests/Elements/View/ViewTests.Android.cs

@@ -9,6 +9,7 @@
 using Microsoft.Maui;
 using Microsoft.Maui.Controls;
 using Microsoft.Maui.Controls.Handlers;
+using Microsoft.Maui.Devices;
 using Microsoft.Maui.DeviceTests.Stubs;
 using Microsoft.Maui.Graphics;
 using Microsoft.Maui.Handlers;
@@ -81,7 +82,8 @@ await CreateHandlerAndAddToWindow(grid, (LayoutHandler handler) =>
 
 						// This fails sometimes due to the way we arrange the content based on coordinates instead of size
 						// Assert.Equal(expectedWidth, pxFrame.Width);
-						Assert.True(pxFrame.Left == lastRight);
+
+						Assert.True(pxFrame.Left == lastRight, $"ColumnCount: {columnCount} Expected Left {lastRight} but got {pxFrame.Left} for child {i} Device Info: {DeviceDisplay.Current.MainDisplayInfo}");
 
 						lastRight = pxFrame.Right;
 					}

src/Controls/tests/DeviceTests/Stubs/WindowHandlerStub.Android.cs

@@ -17,6 +17,11 @@ public class WindowHandlerStub : ElementHandler<IWindow, AActivity>, IWindowHand
 			[nameof(IWindow.Content)] = MapContent
 		};
 
+		public static CommandMapper<IWindow, IWindowHandler> CommandMapper = new(ElementCommandMapper)
+		{
+			[nameof(IWindow.RequestDisplayDensity)] = WindowHandler.MapRequestDisplayDensity,
+		};
+
 		public AView PlatformViewUnderTest { get; private set; }
 
 		void UpdateContent()
@@ -50,7 +55,7 @@ protected override void DisconnectHandler(AActivity platformView)
 		}
 
 		public WindowHandlerStub()
-			: base(WindowMapper)
+			: base(WindowMapper, CommandMapper)
 		{
 		}
 

src/Controls/tests/TestCases.HostApp/Issues/Issue28117.cs

@@ -0,0 +1,31 @@
+namespace Maui.Controls.Sample.Issues;
+
+[Issue(IssueTracker.Github, 28117, "Label text is cropped inside the border control with a specific padding value on certain Android devices", PlatformAffected.Android)]
+public class Issue28117 : ContentPage
+{
+	public Issue28117()
+	{
+		Content = new VerticalStackLayout
+		{
+			WidthRequest = 350,
+			Children =
+			{
+				new Border()
+				{
+					Padding =  new Thickness(70.89827027958738, 0, 0, 0),
+					Margin = new Thickness(10),
+					StrokeThickness = 1,
+					Stroke = Colors.Black,
+					Content =
+					new Label
+					{
+						AutomationId = "Label",
+						FontFamily = "OpenSansRegular",
+						FontSize = 16,
+						Text = "At any time, but not later than one month before the expiration date"
+					}
+				},
+			}
+		};
+	}
+}

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue28117.cs

@@ -0,0 +1,22 @@
+#if !MACCATALYST // On Mac platform, Label does not wrap properly when a width request is set https://github.com/dotnet/maui/issues/15559
+using NUnit.Framework;
+using UITest.Appium;
+using UITest.Core;
+
+namespace Microsoft.Maui.TestCases.Tests.Issues;
+
+public class Issue28117 : _IssuesUITest
+{
+	public Issue28117(TestDevice device) : base(device) { }
+
+	public override string Issue => "Label text is cropped inside the border control with a specific padding value on certain Android devices";
+
+	[Test]
+	[Category(UITestCategories.Border)]
+	public void ShouldDisplayLabelWithoutBeingCroppedInsideBorder()
+	{
+		App.WaitForElement("Label");
+		VerifyScreenshot();
+	}
+}
+#endif

src/Core/src/IViewWithWindow.cs

@@ -0,0 +1,17 @@
+#nullable enable
+
+namespace Microsoft.Maui
+{
+	/// <summary>
+	/// Internal interface for views that can provide access to their window.
+	/// This enables dependency injection for testing scenarios.
+	/// </summary>
+	// TODO Delete this in NET10 and just add it with a default implementation to IView
+	internal interface IViewWithWindow
+	{
+		/// <summary>
+		/// Gets the window associated with this view.
+		/// </summary>
+		IWindow? Window { get; }
+	}
+}