Adopt DensityValue in Grid to Enable Precise Pixel-Aware Layout#30020

Closed

Copilot wants to merge 46 commits into

mainfrom

copilot/fix-30017

Commits on Jun 30, 2025

Initial plan for issue

Copilot
authored and
PureWeen
committed
Initial analysis and plan for DensityValue implementation

authored and
PureWeen
committed
Add DensityValue struct and enhance GridLayoutManager with density-aware star resolution

authored and
PureWeen
committed
Add comprehensive tests for DensityValue pixel distribution scenarios

authored and
PureWeen
committed
Revert Templates/src JSON files and enhance copilot instructions

Copilot
and
PureWeen
committed
Create IWindow.GetDisplayDensity extension method with platform-specific implementations

Copilot
and
PureWeen
committed
Remove GetDisplayDensity extension method and use window.RequestDisplayDensity() instead

Copilot
and
PureWeen
committed
Remove all changes to WindowExtensions.cs as requested

Copilot
and
PureWeen
committed
Add GridLayoutManager tests for DensityValue scenarios from PR description

authored and
PureWeen
committed
Copy changes from PR #28259 to fix label text cropping in Border controls

Copilot
and
PureWeen
committed
Fix compilation error by removing unused variable

Copilot
and
PureWeen
committed
Remove Tizen ViewExtensions changes and add conditional compilation for platform compatibility

Copilot
and
PureWeen
committed
Address code review feedback: remove TIZEN ifdefs, add error logging, remove reflection from tests

Copilot
and
PureWeen
committed
Add ArrangesContentWithoutOverlapAndWithProperSize test replicating device test at density 2.75

Copilot
and
PureWeen
committed
Revert Templates JSON files that should not be committed

Copilot
and
PureWeen
committed
Update tests to validate RawPx values instead of Dp values

Copilot
and
PureWeen
committed
Implement IViewWithWindow interface and density-aware test infrastructure for GridLayoutManager

Copilot
and
PureWeen
committed
Update tests to use tolerance-based comparisons while maintaining density-aware infrastructure

Copilot
and
PureWeen
committed
Fix density-aware tests to use tolerance-based comparisons and focus on pixel precision

Copilot
and
PureWeen
committed
Implement IViewWithWindow interface for density-aware testing and update copilot instructions

Copilot
and
PureWeen
committed
Add debugging test to investigate density-aware distribution failure

Copilot
and
PureWeen
committed
Refactor GridLayoutManager to use pixel-first DensityValue approach

Copilot
and
PureWeen
committed
Complete pixel-first DensityValue refactor with runtime compatibility

Copilot
and
PureWeen
committed
Update Cell to use DensityValue for pixel-precise measurements and fix star resolution control flow

Copilot
and
PureWeen
committed
Add debugging to trace precision loss between star resolution and cell arrangement

Copilot
and
PureWeen
committed
Convert MinimumSize property in Definition class to use DensityValue for pixel-precise calculations

Copilot
and
PureWeen
committed
Revert Templates JSON files and enhance copilot instructions for preventing future commits

Copilot
and
PureWeen
committed
Fix backward compatibility for density-aware Grid layout when density is 1.0

Copilot
and
PureWeen
committed
Address review feedback: use Math.Floor, implement right-to-left pixel distribution, and update test expectations

Copilot
and
PureWeen
committed
- add additional logging to device tests
PureWeen
committed
Address review feedback: add density 2.625 tests and revert Templates JSON files

Copilot
and
PureWeen
committed
Complete density 2.625 tests with correct pixel expectations and fix test infrastructure

Copilot
and
PureWeen
committed
- fix stub
PureWeen
committed
Fix ViewsInUnconstrainedStarRowsDoNotOverlapWhenArrangeHeightChanges test by preserving fractional precision when density=1.0

Copilot
and
PureWeen
committed
Fix pixel distribution algorithm and address structural review feedback - remove TryExpandStarDefinitionsWithDensityAwareness and fix ResolveStars for loop placement

Copilot
and
PureWeen
committed
Remove debug output and identify core issue with density-aware star expansion

Copilot
and
PureWeen
committed
Fix failing ArrangesContentWithoutOverlapAndWithProperSize tests: use minimal view sizes, Math.Floor for pixel calculations, and dynamic expected value calculation

Copilot
and
PureWeen
committed
Restore GridLayoutManager to original implementation with DensityValue type replacement

Copilot
and
PureWeen
committed
Fix failing tests by restoring GridLayoutManager to use DensityValue with proper backward compatibility

Copilot
and
PureWeen
committed
Implement density-aware Grid star sizing for pixel-perfect layout

Copilot
and
PureWeen
committed
Integrate density-aware logic into ExpandStars method and remove Pre-Completion Checklist

Copilot
and
PureWeen
committed
Remove density conditional logic from ExpandStars method

Copilot
and
PureWeen
committed
Fix compilation errors and maintain backwards compatibility for density=1.0

Copilot
and
PureWeen
committed
Remove conditional density logic and unify star expansion algorithm

Copilot
and
PureWeen
committed
Fix failing tests by setting appropriate density values for pixel-perfect distribution

Copilot
and
PureWeen
committed
- update screen shots
PureWeen
committed