[iOS] CollectionView2 - empty view - improvements2#29154
Closed
kubaflo wants to merge 1 commit intodotnet:mainfrom
Closed
[iOS] CollectionView2 - empty view - improvements2#29154kubaflo wants to merge 1 commit intodotnet:mainfrom
kubaflo wants to merge 1 commit intodotnet:mainfrom
Conversation
kubaflo
changed the title
pictos
reviewed
Apr 23, 2025
| emptyViewCell.PlatformHandler = null; | ||
|
|
||
| //Wrapping empty view in a container to enable vertical and horizontal alignment | ||
| var emptyView = ItemsView?.EmptyView as View; |
Contributor
There was a problem hiding this comment.
this can be null? If don't we can remove the ? if yes we should check for null in order to avoid a NRE
Contributor
Author
There was a problem hiding this comment.
I think it can be null
kubaflo
force-pushed
the
cv2-empty-view
branch
2 times, most recently
from
360441a to
5743d65
Compare
Contributor
Author
|
Closed in favour of #31215 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues Fixed
Fixes #28118
Screen.Recording.2025-03-01.at.16.06.17.mov
Screen.Recording.2025-03-01.at.16.04.15.mov
CC @albyrock87 @rmarinho