Skip to content

[iOS] Empty View Overlapping Header in CollectionView with CollectionViewHandler2#27988

Closed
kubaflo wants to merge 3 commits intodotnet:mainfrom
kubaflo:cv2-empty-view-with-footer-and-header
Closed

[iOS] Empty View Overlapping Header in CollectionView with CollectionViewHandler2#27988
kubaflo wants to merge 3 commits intodotnet:mainfrom
kubaflo:cv2-empty-view-with-footer-and-header

Conversation

@kubaflo
Copy link
Copy Markdown
Contributor

@kubaflo kubaflo commented Feb 23, 2025

Issues Fixed

Fixes #25606

Before After

@kubaflo kubaflo requested a review from a team as a code owner February 23, 2025 14:52
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Feb 23, 2025
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@kubaflo kubaflo added platform/ios collectionview-cv2 area-controls-collectionview CollectionView, CarouselView, IndicatorView labels Feb 23, 2025
@jsuarezruiz
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

@rmarinho rmarinho added this to the .NET 9 SR5 milestone Feb 24, 2025
@rmarinho rmarinho self-assigned this Feb 24, 2025
Copy link
Copy Markdown
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems it s failing some tests
CollectionViewHeaderBlankWhenLastItemRemoved-diff 1
CollectionViewHeaderBlankWhenLastItemRemoved

@jsuarezruiz
Copy link
Copy Markdown
Contributor

Seems it s failing some tests CollectionViewHeaderBlankWhenLastItemRemoved-diff 1 CollectionViewHeaderBlankWhenLastItemRemoved

Yes, a list of failing tests on iOS and Catalyst:
image

Copy link
Copy Markdown
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you try some of the failing tests to see if can detect the issue/differences?

@kubaflo
Copy link
Copy Markdown
Contributor Author

kubaflo commented Feb 27, 2025

@rmarinho @jsuarezruiz could you please /azp again?

@PureWeen PureWeen modified the milestones: .NET 9 SR5, .NET 9 SR6 Mar 7, 2025
@PureWeen PureWeen modified the milestones: .NET 9 SR6, .NET 9 SR7 Mar 24, 2025
@PureWeen PureWeen modified the milestones: .NET 9 SR7, .NET 9 SR8 May 8, 2025
@kubaflo
Copy link
Copy Markdown
Contributor Author

kubaflo commented May 10, 2025

Closing in favour of #29154

@kubaflo kubaflo closed this May 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-collectionview CollectionView, CarouselView, IndicatorView collectionview-cv2 community ✨ Community Contribution platform/ios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Empty View Overlapping Header in CollectionView with CollectionViewHandler2 in .Net9

4 participants