-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[iOS] Back-navigation with swipe-back navigates back twice - fix #28485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
PureWeen
merged 3 commits into
dotnet:inflight/candidate
from
kubaflo:Back-navigation-with-swipe-back-navigates-back-twice
Mar 24, 2025
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| namespace Maui.Controls.Sample.Issues; | ||
| [Issue(IssueTracker.Github, 28485, "Back-navigation with swipe-back navigates back twice", PlatformAffected.iOS)] | ||
| public class Issue28485 : Shell | ||
| { | ||
| public Issue28485() | ||
| { | ||
| Routing.RegisterRoute("page2", typeof(Issue28485Page2)); | ||
| Routing.RegisterRoute("page3", typeof(Issue28485Page3)); | ||
|
|
||
| var page1 = new ShellContent | ||
| { | ||
| Title = "Page 1", | ||
| Content = new ContentPage() | ||
| { | ||
| Content = new Button | ||
| { | ||
| Text = "Go to Page 2", | ||
| AutomationId = "GotoPage2", | ||
| Command = new Command(async () => | ||
| { | ||
| await Shell.Current.GoToAsync("page2", false); | ||
| }) | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| Items.Add(page1); | ||
| } | ||
|
|
||
| class Issue28485Page2 : ContentPage | ||
| { | ||
| public Issue28485Page2() | ||
| { | ||
| Title = "Page 1"; | ||
| Content = new StackLayout | ||
| { | ||
| Children = | ||
| { | ||
| new Label { Text = "Welcome to Page 2", AutomationId="Page2Label" }, | ||
| new Button | ||
| { | ||
| Text = "Go to Page 3", | ||
| AutomationId = "GotoPage3", | ||
| Command = new Command(async () => | ||
| { | ||
| await Shell.Current.GoToAsync("page3", false); | ||
| }) | ||
| } | ||
| } | ||
| }; | ||
| } | ||
| } | ||
|
|
||
| class Issue28485Page3 : ContentPage | ||
| { | ||
| public Issue28485Page3() | ||
| { | ||
| Title = "Page 3"; | ||
| Content = new Label { Text = "Welcome to Page 3", AutomationId = "Page3Label" }; | ||
| } | ||
| } | ||
| } |
31 changes: 31 additions & 0 deletions
31
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue28485.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| #if IOS | ||
| using NUnit.Framework; | ||
| using UITest.Appium; | ||
| using UITest.Core; | ||
|
|
||
| namespace Microsoft.Maui.TestCases.Tests.Issues; | ||
|
|
||
| public class Issue28485 : _IssuesUITest | ||
| { | ||
| public Issue28485(TestDevice testDevice) : base(testDevice) | ||
| { | ||
| } | ||
|
|
||
| public override string Issue => "Back-navigation with swipe-back navigates back twice"; | ||
|
|
||
| [Test] | ||
| [Category(UITestCategories.Shell)] | ||
| [Category(UITestCategories.Navigation)] | ||
| public void SwipeBackGestureShouldNavigateOnce() | ||
| { | ||
| App.WaitForElement("GotoPage2"); | ||
| App.Click("GotoPage2"); | ||
| App.WaitForElement("GotoPage3"); | ||
| App.Click("GotoPage3"); | ||
| App.Click("Page3Label"); | ||
| App.InteractivePopGesture(); | ||
| App.WaitForElement("Page2Label"); | ||
| App.WaitForNoElement("GotoPage2"); | ||
| } | ||
| } | ||
| #endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you include an UITest based on https://github.com/Vetle444/MauiTestApp/tree/swipeBackBug?
Can use
App.SwipeLeftToRight();in the test.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, it doesn't work for this iOS-specific-swipe-back gesture
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't it do anything? I can take a look and add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be cool if you could figure it out