Skip to content

[iOS] Back-navigation with swipe-back navigates back twice - fix #28485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 24, 2025
Merged

[iOS] Back-navigation with swipe-back navigates back twice - fix #28485

merged 3 commits into from
Mar 24, 2025

Conversation

@kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Mar 18, 2025 •
edited
Loading

Description

I've made changes to iOS special back navigation in this PR: #24003, but didn't account for the siwpe gesture that behaves differently that the callout-menu-click navigation

Issues Fixed

Fixes #28446
Fixes #28572

Before After
Screen.Recording.2025-03-18.at.20.01.48.mov
Screen.Recording.2025-03-18.at.20.00.04.mov

@kubaflo kubaflo requested a review from a team as a code owner March 18, 2025 19:02
@kubaflo kubaflo requested review from mattleibow and rmarinho March 18, 2025 19:02
@kubaflo kubaflo self-assigned this Mar 18, 2025
@kubaflo kubaflo added platform/ios area-controls-shell Shell Navigation, Routes, Tabs, Flyout labels Mar 18, 2025
@kubaflo kubaflo mentioned this pull request Mar 18, 2025
Closed
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Mar 18, 2025
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Mar 18, 2025

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@jfversluis
Copy link
Member

jfversluis commented Mar 18, 2025

/azp run

@jfversluis jfversluis added the p/0 Current heighest priority issues that we are targeting for a release. label Mar 18, 2025
@jfversluis jfversluis added this to the .NET 9 SR6 milestone Mar 18, 2025
@azure-pipelines
Copy link

azure-pipelines bot commented Mar 18, 2025

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen moved this from Todo to Ready To Review in MAUI SDK Ongoing Mar 18, 2025
mattleibow
mattleibow requested changes Mar 19, 2025
View reviewed changes
Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to write a UI test for this? I think that the swipe gestures should work?

@github-project-automation github-project-automation bot moved this from Ready To Review to Changes Requested in MAUI SDK Ongoing Mar 19, 2025
jsuarezruiz
jsuarezruiz suggested changes Mar 19, 2025
View reviewed changes
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellSectionRenderer.cs

public override UIViewController PopViewController(bool animated)
{
_popRequested = true;
Copy link
Contributor

@jsuarezruiz jsuarezruiz Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you include an UITest based on https://github.com/Vetle444/MauiTestApp/tree/swipeBackBug?
Can use App.SwipeLeftToRight(); in the test.

Copy link
Contributor Author

@kubaflo kubaflo Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, it doesn't work for this iOS-specific-swipe-back gesture

Copy link
Contributor

@jsuarezruiz jsuarezruiz Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't it do anything? I can take a look and add it.

Copy link
Contributor Author

@kubaflo kubaflo Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be cool if you could figure it out

@kubaflo
Copy link
Contributor Author

kubaflo commented Mar 19, 2025

Is it possible to write a UI test for this? I think that the swipe gestures should work?

App.SwipeLeftToRight(); doesn't work :/

@jfversluis
Copy link
Member

jfversluis commented Mar 21, 2025

Author of the issue confirms this seems to fix it: #28446 (comment)

@PureWeen PureWeen mentioned this pull request Mar 23, 2025
Closed
@PureWeen
Copy link
Member

PureWeen commented Mar 23, 2025

#28572

@PureWeen PureWeen changed the base branch from main to inflight/candidate March 23, 2025 23:38
PureWeen
PureWeen previously approved these changes Mar 23, 2025
View reviewed changes
@PureWeen PureWeen dismissed their stale review March 23, 2025 23:42

Needs additional review

@PureWeen PureWeen moved this from Changes Requested to Ready To Review in MAUI SDK Ongoing Mar 24, 2025
@rmarinho
Copy link
Member

rmarinho commented Mar 24, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 24, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@PureWeen PureWeen merged commit aea605d into dotnet:inflight/candidate Mar 24, 2025
12 of 19 checks passed
@github-project-automation github-project-automation bot moved this from Ready To Review to Done in MAUI SDK Ongoing Mar 24, 2025
@PureWeen
Copy link
Member

PureWeen commented Mar 24, 2025

/backport to release/9.0.1xx-sr5

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2025

Started backporting to release/9.0.1xx-sr5: https://github.com/dotnet/maui/actions/runs/14043250116

@github-actions github-actions bot mentioned this pull request Mar 24, 2025
Merged
@sheiksyedm
Copy link
Contributor

sheiksyedm commented Mar 26, 2025

@kubaflo SwipeBackGestureShouldNavigateOnce tests fail on the below PR. Can you check this?

#28560

image

CC: @PureWeen

@kubaflo kubaflo mentioned this pull request Mar 26, 2025
Merged
@kubaflo
Copy link
Contributor Author

kubaflo commented Mar 26, 2025

@sheiksyedm I believe this should help :) #28644

PureWeen pushed a commit that referenced this pull request Mar 26, 2025
@kubaflo @PureWeen
[iOS] Back-navigation with swipe-back navigates back twice - fix (#28485
1fced66 
)
github-actions bot pushed a commit that referenced this pull request Mar 27, 2025
@kubaflo @rmarinho
[iOS] Back-navigation with swipe-back navigates back twice - fix (#28485
ae5af8d 
)
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mattleibow mattleibow mattleibow requested changes

@PureWeen PureWeen PureWeen left review comments

@rmarinho rmarinho Awaiting requested review from rmarinho rmarinho was automatically assigned from dotnet/dotnet-maui-reviewers

+1 more reviewer

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kubaflo kubaflo

Labels

area-controls-shell Shell Navigation, Routes, Tabs, Flyout community ✨ Community Contribution p/0 Current heighest priority issues that we are targeting for a release. platform/ios

Projects

MAUI SDK Ongoing
Status: Done

Milestone

.NET 9 SR6

Development

Successfully merging this pull request may close these issues.

[iOS] Back-navigation with swipe-back navigates back twice

7 participants

@kubaflo @jfversluis @PureWeen @rmarinho @sheiksyedm @mattleibow @jsuarezruiz