[NET10.0] Annotate ListStringTypeConverter for nullability#28244
Merged
rmarinho merged 1 commit intodotnet:net10.0from Mar 20, 2025
Merged
Conversation
Contributor
|
Hey there @MartyIX! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
jfversluis
previously approved these changes
Mar 7, 2025
rmarinho
requested changes
Mar 7, 2025
Member
rmarinho
left a comment
There was a problem hiding this comment.
I think the publicAPI changes are wrong, you need to add [Remove] tag on unshipped , the Shipped should not be changed..
Contributor
Author
Hopefully, it's correct now. |
jsuarezruiz
previously approved these changes
Mar 10, 2025
rmarinho
requested changes
Mar 10, 2025
Member
rmarinho
left a comment
There was a problem hiding this comment.
/Users/builder/azdo/_work/1/s/src/Controls/src/Core/PublicAPI/net-android/PublicAPI.Unshipped.txt(197,1): error RS0050: Symbol '~override Microsoft.Maui.Controls.ListStringTypeConverter.CanConvertFrom(System.ComponentModel.ITypeDescriptorContext context, System.Type sourceType) -> bool' is marked as removed but it isn't deleted in source code (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/Users/builder/azdo/_work/1/s/src/Controls/src/Core/Controls.Core.csproj::TargetFramework=net10.0-android35.0]
/Users/builder/azdo/_work/1/s/src/Controls/src/Core/PublicAPI/net-android/PublicAPI.Unshipped.txt(198,1): error RS0050: Symbol '~override Microsoft.Maui.Controls.ListStringTypeConverter.CanConvertTo(System.ComponentModel.ITypeDescriptorContext context, System.Type destinationType) -> bool' is marked as removed but it isn't deleted in source code (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/Users/builder/azdo/_work/1/s/src/Controls/src/Core/Controls.Core.csproj::TargetFramework=net10.0-android35.0]
/Users/builder/azdo/_work/1/s/src/Controls/src/Core/PublicAPI/net-android/PublicAPI.Unshipped.txt(199,1): error RS0050: Symbol '~override Microsoft.Maui.Controls.ListStringTypeConverter.ConvertFrom(System.ComponentModel.ITypeDescriptorContext context, System.Globalization.CultureInfo culture, object value) -> object' is marked as removed but it isn't deleted in source code (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/Users/builder/azdo/_work/1/s/src/Controls/src/Core/Controls.Core.csproj::TargetFramework=net10.0-android35.0]
/Users/builder/azdo/_work/1/s/src/Controls/src/Core/PublicAPI/net-android/PublicAPI.Unshipped.txt(200,1): error RS0050: Symbol '~override Microsoft.Maui.Controls.ListStringTypeConverter.ConvertTo(System.ComponentModel.ITypeDescriptorContext context, System.Globalization.CultureInfo culture, object value, System.Type destinationType) -> object' is marked as removed but it isn't deleted in source code (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md) [/Users/builder/azdo/_work/1/s/src/Controls/src/Core/Controls.Core.csproj::TargetFramework=net10.0-android35.0]
1 Warning(s)
24 Error(s)
Seems something is wrong, you can test locally first see if dotnet cake --workloads=global works
a83f02a to
fdf32fb
Compare
fdf32fb to
bdfdfc1
Compare
rmarinho
approved these changes
Mar 19, 2025
rmarinho
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Recently, a PR was merged (#27984) where nullability annotations for
ShadowTypeConverterwere added. However, I believe that there are minor errors.Based on dotnet/runtime#63874 which corrected nullable types for .NET runtime (e.g. DateTimeConverter), I believe that the correct method synopses are:
This PR attempts to fix the annotations for a single converter to validate my beliefs.
If you wonder, what "~" character (called oblivious marker) denotes in
PublicAPI.Shipped.txtandPublicAPI.Unshipped.txtfiles mean, then look here: https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md#nullable-reference-type-support