Annotate ListStringTypeConverter for nullability#28217
Closed
MartyIX wants to merge 1 commit intodotnet:mainfrom
Closed
Annotate ListStringTypeConverter for nullability#28217MartyIX wants to merge 1 commit intodotnet:mainfrom
ListStringTypeConverter for nullability#28217MartyIX wants to merge 1 commit intodotnet:mainfrom
Conversation
Note: See explanation of "~" character here: https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md#nullable-reference-type-support > Any public API that haven't been annotated (i.e. uses an oblivious reference type) will be tracked with a `~` marker. > The marker lets you track how many public APIs still lack annotations. For instance, `~C.ObliviousMethod() -> string`. See also: dotnet/runtime#63874 which corrected nullable types for .NET runtime (e.g. https://github.com/dotnet/runtime/blob/78142b0e78681a3be581040c7b988bc91d5a8169/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/DateTimeConverter.cs)
Contributor
|
Hey there @MartyIX! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
|
This should be targeting main? |
Contributor
Author
I can retarget if it is not good for |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
Not sure to what extend this is actually breaking, but just to be sure lets make this target .NET 10 since it does touch public APIs |
Contributor
Author
|
I believe it's not a breaking change but I'm not 100 per cent sure. I created #28244 for NET 10.0, given that tests run and I'm interested if there is an issue or not. |
Member
|
Lets keep this for .NET 10! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Recently, a PR was merged (#27984) where nullability annotations for
ShadowTypeConverterwere added. However, I believe that there are minor errors.Based on dotnet/runtime#63874 which corrected nullable types for .NET runtime (e.g. DateTimeConverter), I believe that the correct method synopses are:
This PR attempts to fix the annotations for a single converter to validate my beliefs.
If you wonder, what "~" character (called oblivious marker) denotes in
PublicAPI.Shipped.txtandPublicAPI.Unshipped.txtfiles mean, then look here: https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md#nullable-reference-type-support