[Testing] Enabling more UI Tests by removing platform specific condition - 15 #27965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LogishaSelvarajSF4525
added
area-testing
Contributor
|
Hey there @LogishaSelvarajSF4525! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
There was a problem hiding this comment.
Copilot reviewed 7 out of 12 changed files in this pull request and generated no comments.
Files not reviewed (5)
- src/Controls/tests/TestCases.HostApp/Issues/ScrollViewObjectDisposed.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/ScrollViewObjectDisposed.cs: Evaluated as low risk
- src/Controls/tests/TestCases.HostApp/Issues/Issue6458.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19214_3.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19214_2.cs: Evaluated as low risk
Comments suppressed due to low confidence (2)
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue17453.cs:71
- Changing the method signature from 'async Task' to 'void' could cause issues if the method relies on asynchronous operations. Consider reverting it back to 'async Task'.
public void EntryWithMarginClearButtonWorks()
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue6458.cs:21
- The method VerifyScreenshot is used, but it is not clear if this method is defined and what it does. Ensure that this method is properly defined and covered by tests.
VerifyScreenshot();
jsuarezruiz
suggested changes
Feb 24, 2025
| [Category(UITestCategories.Navigation)] | ||
| [Category(UITestCategories.Compatibility)] | ||
| [FailsOnAndroidWhenRunningOnXamarinUITest] | ||
| public void Issue6458Test() |
Contributor
There was a problem hiding this comment.
This test is failing on Mac and Windows. Pending snapshots, already available in the latest build:
Example:
Contributor
Author
There was a problem hiding this comment.
@jsuarezruiz I have committed this snapshot in the latest changes.
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
suggested changes
Feb 27, 2025
| [Test] | ||
| [Category(UITestCategories.Entry)] | ||
| public async Task EntryWithMarginClearButtonWorks() | ||
| public void EntryWithMarginClearButtonWorks() |
Contributor
There was a problem hiding this comment.
This test is failing on Android:
Assert.That(aString, new EmptyStringConstraint())
Expected: <empty>
But was: "Simple text"
Contributor
Author
There was a problem hiding this comment.
@jsuarezruiz Modified the test to ensure it runs on Android and committed the code changes.
| [Description("Tapping a button inside the ScrollView does not cause an exception.")] | ||
| [FailsOnAndroidWhenRunningOnXamarinUITest("This test is failing, likely due to product issue")] | ||
| [FailsOnWindowsWhenRunningOnXamarinUITest("This test is failing, likely due to product issue")] | ||
| public void ScrollViewObjectDisposedTest() |
Contributor
There was a problem hiding this comment.
This test is failing on Android:
at UITest.Appium.HelperExtensions.Click(IUIElement element) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 287
at UITest.Appium.HelperExtensions.Tap(IApp app, String element) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 25
at Microsoft.Maui.TestCases.Tests.Issues.ScrollViewObjectDisposedUITests.ScrollViewObjectDisposedTest() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/ScrollViewObjectDisposed.cs:line 22
at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
Contributor
Author
There was a problem hiding this comment.
@jsuarezruiz Modified the test to ensure it runs on Android and committed the code changes.
Contributor
|
/rebase |
github-actions
bot
force-pushed
the
logi-enableuitests14
branch
from
638097e to
6992a2b
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
approved these changes
Mar 14, 2025
PureWeen
pushed a commit
that referenced
this pull request
Mar 26, 2025
…ion - 15 (#27965) * enable the test case for all platforms * enable ScrollViewObjectDisposed.cs * updated the changes * modified * added the snapshot * added snapshot * modified changes * Update Issue17453.cs * modified Issue17453.cs
PureWeen
pushed a commit
that referenced
this pull request
Mar 26, 2025
…ion - 15 (#27965) * enable the test case for all platforms * enable ScrollViewObjectDisposed.cs * updated the changes * modified * added the snapshot * added snapshot * modified changes * Update Issue17453.cs * modified Issue17453.cs
github-actions bot
pushed a commit
that referenced
this pull request
Mar 27, 2025
…ion - 15 (#27965) * enable the test case for all platforms * enable ScrollViewObjectDisposed.cs * updated the changes * modified * added the snapshot * added snapshot * modified changes * Update Issue17453.cs * modified Issue17453.cs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The tests, previously added for specific platforms alone, now we are reviewed, and enabled the tests in all applicable platforms with the Appium framework. We are going to enable tests in blocks in different PRs. This is the 15th group of tests enabled.
Test Cases:
Fixes #22902