[Testing] Enabling more UI Tests by removing platform specific condition - 15 (#27965)

* enable the test case for all platforms

* enable ScrollViewObjectDisposed.cs

* updated the changes

* modified

* added the snapshot

* added snapshot

* modified changes

* Update Issue17453.cs

* modified Issue17453.cs

Author: LogishaSelvarajSF4525

src/Controls/tests/TestCases.Android.Tests/snapshots/android/Issue6458Test.png

@@ -1,21 +1,27 @@
 namespace Maui.Controls.Sample.Issues
 {
 	[Issue(IssueTracker.Github, 6458, "[Android] Fix load TitleIcon on non app compact", PlatformAffected.Android)]
-	public class Issue6458 : TestContentPage // or TestFlyoutPage, etc ...
+	public class Issue6458 : TestNavigationPage // or TestFlyoutPage, etc ...
 	{
 		protected override void Init()
 		{
-			NavigationPage.SetTitleIconImageSource(this,
+			var contentPage = new ContentPage
+			{
+				Content = new Label
+				{
+					AutomationId = "IssuePageLabel",
+					Text = "Make sure you run this on Non AppCompact Activity"
+				}
+			};
+
+			NavigationPage.SetTitleIconImageSource(contentPage,
 				new FileImageSource
 				{
 					File = "bank.png",
 					AutomationId = "banktitleicon"
 				});
-			Content = new Label
-			{
-				AutomationId = "IssuePageLabel",
-				Text = "Make sure you run this on Non AppCompact Activity"
-			};
+
+			this.PushAsync(contentPage);
 		}
 	}
 }

src/Controls/tests/TestCases.HostApp/Issues/Issue6458.cs

@@ -7,37 +7,42 @@ public class ScrollViewObjectDisposed : ContentPage
 		const string Instructions = "Tap the button. If the app does not crash and the red label displays \"Success\", this test has passed.";
 		const string Success = "Success";
 		const string TestButtonId = "TestButtonId";
-
-		readonly Label _status = new Label() { Text = "Test is running...", BackgroundColor = Colors.Red, TextColor = Colors.White };
-		readonly ScrollView _scroll = new ScrollView();
+		Label _status;
+		ScrollView _scroll;
 
 		public ScrollViewObjectDisposed()
 		{
-			_scroll.Content = _status;
-
 			InitTest();
 		}
 
 		void InitTest()
 		{
-			Button nextButton = new Button { Text = "Next", AutomationId = TestButtonId };
-			nextButton.Clicked += NextButton_Clicked;
+			 _status = new Label() { Text = "Test is running...", BackgroundColor = Colors.Red, TextColor = Colors.White };
 
-			StackLayout stack = new StackLayout
+			_scroll = new ScrollView
 			{
-				Children = { new Label { Text = Instructions }, _scroll, nextButton }
+				Content = _status
 			};
 
-			Content = stack;
+			Button nextButton = new Button { Text = "Next", AutomationId = TestButtonId };
+			nextButton.Clicked += NextButton_Clicked;
+			var stack = new StackLayout
+			{
+				Children =
+				{
+					new Label { Text = Instructions },
+					_scroll,
+					nextButton
+				}
+			};
+			this.Content = stack;
 		}
-
 		void NextButton_Clicked(object sender, EventArgs e)
 		{
 			_status.Text = string.Empty;
-
 			InitTest();
-
 			_status.Text = Success;
 		}
 	}
-}
+}
+

src/Controls/tests/TestCases.HostApp/Issues/ScrollViewObjectDisposed.cs

@@ -1,4 +1,5 @@
-using System.Drawing;
+#if TEST_FAILS_ON_CATALYST //related issue: https://github.com/dotnet/maui/issues/17435
+using System.Drawing;
 using NUnit.Framework;
 using NUnit.Framework.Legacy;
 using OpenQA.Selenium.Appium.Interactions;
@@ -86,3 +87,4 @@ static void AssertCorrectTapLocation(string tapData, float expectedX, float expe
 		}
 	}
 }
+#endif

src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/Issue6458Test.png

@@ -1,5 +1,4 @@
-#if ANDROID
-using NUnit.Framework;
+using NUnit.Framework;
 using NUnit.Framework.Legacy;
 using UITest.Appium;
 using UITest.Core;
@@ -11,6 +10,7 @@ class Issue17453 : _IssuesUITest
 		public Issue17453(TestDevice device) : base(device) { }
 
 		public override string Issue => "Clear Entry text tapping the clear button not working";
+		protected override bool ResetAfterEachTest => true;
 
 		[Test]
 		[Category(UITestCategories.Entry)]
@@ -19,12 +19,12 @@ public void EntryClearButtonWorksEntryDoesntClearWhenNotClickingOnClear()
 			// https://github.com/dotnet/maui/issues/17453
 
 			App.WaitForElement("WaitForStubControl");
-			string? rtlEntryText = App.FindElement("RtlEntry").GetText();
+			string? rtlEntryText = App.WaitForElement("RtlEntry").GetText();
 
 			if (String.IsNullOrWhiteSpace(rtlEntryText))
 				App.EnterText("RtlEntry", "Simple Text");
 
-			var rtlEntryRect = App.FindElement("RtlEntry").GetRect();
+			var rtlEntryRect = App.WaitForElement("RtlEntry").GetRect();
 			App.EnterText("RtlEntry", "Simple Text");
 
 			// Set focus
@@ -33,7 +33,7 @@ public void EntryClearButtonWorksEntryDoesntClearWhenNotClickingOnClear()
 			// Tap on the entry but not on the clear button
 			App.TapCoordinates(rtlEntryRect.CenterX(), rtlEntryRect.CenterY());
 
-			rtlEntryText = App.FindElement("RtlEntry").GetText();
+			rtlEntryText = App.WaitForElement("RtlEntry").GetText();
 
 			ClassicAssert.IsNotEmpty(rtlEntryText);
 		}
@@ -46,50 +46,57 @@ public void EntryClearButtonWorks()
 
 			App.WaitForElement("WaitForStubControl");
 
-			string? rtlEntryText = App.FindElement("RtlEntry").GetText();
+			string? rtlEntryText = App.WaitForElement("RtlEntry").GetText();
 
 			if (String.IsNullOrWhiteSpace(rtlEntryText))
 				App.EnterText("RtlEntry", "Simple Text");
 
-			var rtlEntryRect = App.FindElement("RtlEntry").GetRect();
+			var rtlEntryRect = App.WaitForElement("RtlEntry").GetRect();
 
 			// Set focus
-			App.TapCoordinates(rtlEntryRect.X, rtlEntryRect.Y);
+			App.TapCoordinates(rtlEntryRect.CenterX(), rtlEntryRect.CenterY());
 
+			App.WaitForElement("RtlEntry");
 			// Tap Clear Button
-			var margin = 30;
-			App.TapCoordinates(rtlEntryRect.X + margin, rtlEntryRect.Y + margin);
+			var margin = 10;
+			App.TapCoordinates(rtlEntryRect.X + margin, rtlEntryRect.CenterY());
 
-			rtlEntryText = App.FindElement("RtlEntry").GetText();
+			rtlEntryText = App.WaitForElement("RtlEntry").GetText();
 
 			ClassicAssert.IsEmpty(rtlEntryText);
 		}
 
 		[Test]
 		[Category(UITestCategories.Entry)]
-		public async Task EntryWithMarginClearButtonWorks()
+		public void EntryWithMarginClearButtonWorks()
 		{
 			// https://github.com/dotnet/maui/issues/25225
 
 			App.WaitForElement("WaitForStubControl");
 
-			string? entryText = App.FindElement("EntryWithMargin").GetText();
+			string? entryText = App.WaitForElement("EntryWithMargin").GetText();
 			if (String.IsNullOrWhiteSpace(entryText))
 				App.EnterText("EntryWithMargin", "Simple Text");
 
-			var entryRect = App.FindElement("EntryWithMargin").GetRect();
+			var entryRect = App.WaitForElement("EntryWithMargin").GetRect();
 
 			// Set focus
-			App.TapCoordinates(entryRect.Width, entryRect.Y);
-			await Task.Delay(500);
+			App.TapCoordinates(entryRect.CenterX(), entryRect.CenterY());
+
+			App.WaitForElement("EntryWithMargin");
 
+#if ANDROID
+			if (App.IsKeyboardShown())
+			{
+				App.DismissKeyboard();
+			}
+#endif
 			// Tap Clear Button
-			App.TapCoordinates(entryRect.Width, entryRect.Y);
+			App.TapCoordinates(entryRect.X + entryRect.Width - 17, entryRect.CenterY());
 
-			entryText = App.FindElement("EntryWithMargin").GetText();
+			entryText = App.WaitForElement("EntryWithMargin").GetText();
 
 			ClassicAssert.IsEmpty(entryText);
 		}
 	}
-}
-#endif
+}

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue16561.cs

@@ -1,4 +1,5 @@
-#if IOS
+#if IOS || (ANDROID && TEST_FAILS_ON_ANDROID)//android related issue: https://github.com/dotnet/maui/issues/27951
+//The test is applicable only to mobile platforms like iOS and Android.
 using System.Drawing;
 using NUnit.Framework;
 using NUnit.Framework.Legacy;

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue17453.cs

@@ -1,4 +1,4 @@
-#if IOS
+#if IOS //This sample is specific to the iOS platform and handles text input behavior by accessing the native UITextView.
 using System.Drawing;
 using NUnit.Framework;
 using NUnit.Framework.Legacy;

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19214.cs

@@ -1,4 +1,4 @@
-#if IOS
+#if IOS //This sample is specific to the iOS platform and handles text input behavior by accessing the native UITextView.
 using System.Drawing;
 using NUnit.Framework;
 using NUnit.Framework.Legacy;

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19214_2.cs

@@ -1,4 +1,5 @@
-#if IOS
+#if IOS || (ANDROID && TEST_FAILS_ON_ANDROID)//android related issue: https://github.com/dotnet/maui/issues/27951
+//The test is applicable only to mobile platforms like iOS and Android.
 using System.Drawing;
 using NUnit.Framework;
 using UITest.Appium;
@@ -103,4 +104,4 @@ void CheckForBottomEntry (AppiumApp app)
 		ClassicAssert.Less(bottomEntryRect.Bottom, keyboardPosition!.Value.Y);
     }
 }
-#endif
+#endif