[Android] Fix for Flyout closing when updating the FlyoutPage.Detail#26425
[Android] Fix for Flyout closing when updating the FlyoutPage.Detail#26425PureWeen merged 4 commits intodotnet:net10.0from
Conversation
karthikraja-arumugam
added
the
partner/syncfusion
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Tamilarasan-Paranthaman
requested review from
StephaneDelcroix and
mattleibow
|
/rebase |
github-actions
bot
force-pushed
the
fix-26324
branch
from
b54921f to
8d5618d
Compare
|
Azure Pipelines successfully started running 3 pipeline(s). |
| DrawerLayout.AddView(flyoutView, layoutParameters); | ||
| } | ||
|
|
||
| DrawerLayout.CloseDrawer(flyoutView); |
There was a problem hiding this comment.
Does this mean that the flyout will now never close whenever we select another item? I don't think that is what we want.
There was a problem hiding this comment.
@jfversluis, Currently, the flyout is not closed by default when selecting items in the flyout view across all platforms.
In the reported scenario, the issue arises when the user updates the FlyoutPage.Details while selecting an item in the flyout. This triggers the flyout to close by default. However, it does not close on other platforms, leading to inconsistency across the platforms. Could you please share your insight on this scenario?
Tamilarasan-Paranthaman
changed the title
|
I'd like a bit more discussion on this one. I think the behavior for the Flyout is as it should and it closes whenever you click/tap on an option. The description says on other platforms it does remain open? Is that the case? As far as I know all flyouts close when you tap on something. Lets double-check what is going on here. |
PureWeen
left a comment
PureWeen
left a comment
There was a problem hiding this comment.
#26425 (comment)
Can you create a table on the description with the behavior for each platform?
- What is the behavior of the flyout on each platform when clicking a flyout item?
- What is the behavior of the flyout on each platform when clicking a flyout item and changing the details?
@PureWeen, I have attached a video reference in the description showing the behavior on each platform for both cases. Additionally, based on the details provided in the documentation, it appears that the flyout does not close when updating the details. It seems that we should close the flyout by using the FlyoutPage.IsPresented property to display the detail page. |
There was a problem hiding this comment.
Based on the comparison to other platforms
And the fact that this behavior was changed from XF
I think it makes sense to take this change and call it out in our release notes.
I see that @kubaflo tested this with a native android app.
This is a little interesting because this is a feature that's built into using JET Navigation with DrawerLayout it looks like. So, yes this is how a default android app works but it's still inconsistent with iOS, WinUI and how it worked on XF.
PureWeen
added
t/breaking 💥
needs-breaking-change-doc-created
and removed
do-not-merge
|
🚨 API change(s) detected @davidbritch FYI |
|
We'll take this for .NET10 |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
5 participants
Root Cause of the issue
Description of Change
Issues Fixed
Fixes #26324
Tested the behaviour in the following platforms
Screenshot
Issue.mov
fix.mov
Behavior on each platform
Note: From the video references below, you can see that the flyout closes automatically on Android when FlyoutPage.Detail is updated upon selecting a flyout item. In contrast, on other platforms, the flyout remains open after updating the FlyoutPage.Detail.
Android-Default.mov
Android-Update-Detail.mov
iOS-Default.mov
iOS-Update-Detail.mov
WinUI-Default.mp4
WinUI-Update-Detail.mp4
Mac-Default.mov
Mac-Update-Detail.mov