Skip to content

[Android] Fix for Flyout closing when updating the FlyoutPage.Detail #26425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PureWeen merged 4 commits into from
Feb 7, 2025
Merged

[Android] Fix for Flyout closing when updating the FlyoutPage.Detail #26425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b54921f
FyloutView fix.
Tamilarasan-Paranthaman Dec 6, 2024
8d5618d
FyloutView fix.
Tamilarasan-Paranthaman Dec 6, 2024
e2030ee
Merge branch 'fix-26324' of https://github.com/Tamilarasan-Paranthama…
Tamilarasan-Paranthaman Dec 9, 2024
83c1bff
Updated related test case.
Tamilarasan-Paranthaman Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/XFIssue/Issue892.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public void Issue892TestsNavigateChangePagesNavigate()
App.Tap("Present Flyout");
App.Tap(Page5);

#if ANDROID || WINDOWS // IsPresented value not reflected when changing on ItemTapped in FlyoutPage More Information: https://github.com/dotnet/maui/issues/26324.
#if WINDOWS // IsPresented value not reflected when changing on ItemTapped in FlyoutPage.
App.WaitForElementTillPageNavigationSettled(Page5);
App.TapInFlyoutPageFlyout("Close Flyout");
#else
Expand All @@ -42,10 +42,10 @@ public void Issue892TestsNavigateChangePagesNavigate()

void NavigateToEndAndBack(string BackButtonId)
{
App.WaitForElement("Push next page");
App.WaitForElement("Push next page");
App.Tap("Push next page");
App.WaitForElement("Push next next page");
App.Tap("Push next next page");
App.WaitForElement("Push next next page");
App.Tap("Push next next page");
App.WaitForElement("You are at the end of the line");
App.Tap("Check back one");
App.WaitForElement("Pop one");
Expand Down
4 changes: 1 addition & 3 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/XFIssue/Issue973.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if TEST_FAILS_ON_ANDROID // IsPresented value is not reflected when change this on list view item tapped in flyout. Issue: https://github.com/dotnet/maui/issues/26324
using NUnit.Framework;
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;

Expand Down Expand Up @@ -37,4 +36,3 @@ public void Issue973TestsTabResetAfterDetailSwap()
App.WaitForElement("Page 4 Right aligned");
}
}
#endif
2 changes: 0 additions & 2 deletions src/Core/src/Handlers/FlyoutView/FlyoutViewHandler.Android.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,8 +255,6 @@ void LayoutAsFlyout()
DrawerLayout.AddView(flyoutView, layoutParameters);
}

DrawerLayout.CloseDrawer(flyoutView);
Copy link
Member

@jfversluis jfversluis Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that the flyout will now never close whenever we select another item? I don't think that is what we want.

Copy link
Member Author

@Tamilarasan-Paranthaman Tamilarasan-Paranthaman Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jfversluis, Currently, the flyout is not closed by default when selecting items in the flyout view across all platforms.

In the reported scenario, the issue arises when the user updates the FlyoutPage.Details while selecting an item in the flyout. This triggers the flyout to close by default. However, it does not close on other platforms, leading to inconsistency across the platforms. Could you please share your insight on this scenario?


if (VirtualView is IToolbarElement te && te.Toolbar?.Handler is ToolbarHandler th)
th.SetupWithDrawerLayout(DrawerLayout);
}
Expand Down
Loading