Skip to content

[iOS] Fixed NRE after calling ViewCell.ForceUpdateSize #23094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PureWeen merged 2 commits into from
Jun 18, 2024
Merged

[iOS] Fixed NRE after calling ViewCell.ForceUpdateSize #23094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1fad42
[iOS] Fixed NRE after calling ViewCell.ForceUpdateSize
VitalyKnyazev Jun 17, 2024
70772e0
- add test
PureWeen Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Controls/src/Core/Cells/Cell.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ async void OnForceUpdateSizeRequested()
// don't run more than once per 16 milliseconds
await Task.Delay(TimeSpan.FromMilliseconds(16));
ForceUpdateSizeRequested?.Invoke(this, null);
Handler.Invoke("ForceUpdateSizeRequested", null);
Handler?.Invoke("ForceUpdateSizeRequested", null);

_nextCallToForceUpdateSizeQueued = false;
}
Expand Down
20 changes: 20 additions & 0 deletions src/Controls/tests/Core.UnitTests/ListViewTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1649,5 +1649,25 @@ public void DoesNotRetainInRecycleMode()

Assert.False(ReferenceEquals(item1, item2));
}

[Fact]
public void ForceUpdateSizeCalledOnViewCellDoesntCrash()
{
var list = new ListView(){
HasUnevenRows = true
};

list.ItemTemplate = new DataTemplate(() =>
{
return new ViewCell { View = new Label() };
}
);

list.ItemsSource = new[] { "Hi" };

var element = (ViewCell)list.TemplatedItems[0];

element.ForceUpdateSize();
}
}
}