[controls] improve performance of {Binding} #14830
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote a benchmark for
Binding
, such as:Attaching
dotnet-trace
, I found ~53% of the time was spent inMethodInfo.GetParameters()
:Reviewing the code, it was basically calling:
We can just call
PropertyInfo.PropertyType
instead, to avoid allocating aParameterInfo[]
and indexing into it.The results of this change in my benchmarks:
-- Before
++ After
This should help scrolling performance such as in #12130, where bindings are updating while scrolling.