Correctly re-apply font formatting to HTML text #14701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the text on iOS resets all formatting, so we need to re-apply size, color and other properties.
23 tasks
mattleibow
commented
Apr 21, 2023
| } | ||
|
|
||
| public static void MapText(ILabelHandler handler, Label label) | ||
| { | ||
| Platform.TextViewExtensions.UpdateText(handler.PlatformView, label); | ||
| } | ||
|
|
||
| // TODO: NET8 make this public | ||
| internal static void MapTextColor(ILabelHandler handler, Label label) |
There was a problem hiding this comment.
No longer needed as the new way of Platform.TextViewExtensions.UpdateText() correctly handles span colors. There is no difference with either HTML of formatted text.
| Platform.TextExtensions.UpdateText(handler.PlatformView, label); | ||
| handler.UpdateValue(nameof(ILabel.Text)); |
There was a problem hiding this comment.
Instead of calling the same method, we should be triggering the Text property so people can properly intercept it.
Comment on lines
+26
to
+27
|
|
||
| MapFormatting(handler, label); |
There was a problem hiding this comment.
This is the real iOS fix that re-applied formatting.
Comment on lines
+94
to
+98
| static void MapFormatting(ILabelHandler handler, Label label) | ||
| { | ||
| handler.UpdateValue(nameof(ILabel.TextColor)); | ||
| handler.UpdateValue(nameof(ILabel.Font)); | ||
| } |
There was a problem hiding this comment.
Call the properties that need to be re-applied.
| handler.PlatformView?.UpdateHorizontalTextAlignment(label); | ||
| handler.UpdateValue(nameof(ILabel.HorizontalTextAlignment)); |
There was a problem hiding this comment.
Don't just call the method, trigger the property so that the mappers can re-run.
mattleibow
added
the
backport/suggested
Eilon
added
the
legacy-area-controls
PureWeen
approved these changes
Apr 27, 2023
hartez
added
the
backport/NO
Eilon
added
area-controls-label
samhouts
added
the
fixed-in-8.0.0-preview.4.8333
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Setting the text on iOS resets all formatting, so we need to re-apply size, color and other properties.
Issues Fixed
Fixes #12230
Fixes #11817