[graphics] fix CA1307 and CA1309 for performance #14627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet#12130 Context: https://github.com/angelru/CvSlowJittering While reviewing the above sample, I saw time spent doing culture-aware string "stuff" in Microsoft.Maui.Graphics: 77.22ms microsoft.maui!Microsoft.Maui.Graphics.MauiDrawable.SetDefaultBackgroundColor() 42.55ms System.Private.CoreLib!System.String.ToLower() In c40c6e7, I added code analysis rules to the `.editorconfig`, but it appears we ignored these warnings in dbaeee9. These are generally easy to fix, we should have just addressed these instead of adding `$(NoWarn)`. In the future, I will look into adding `CA1311`: https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1311 This would find `string.ToLower()` calls and recommend `string.ToLowerInvariant()` instead. I fixed the one place I saw it affecting performance in `dotnet-trace`.
jonathanpeppers
commented
Apr 17, 2023
| bool encode = attributedText.Text.Contains("]]"); | ||
| bool encode = attributedText.Text.IndexOf("]]", StringComparison.Ordinal) != -1; |
There was a problem hiding this comment.
Switching to IndexOf() for this one felt better than having to do #if NETSTANDARD2_0.
jonathanpeppers
added
legacy-area-perf
jsuarezruiz
approved these changes
Apr 18, 2023
mattleibow
approved these changes
Apr 18, 2023
Eilon
added
t/perf
samhouts
added
the
fixed-in-8.0.0-preview.4.8333
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #12130
Context: https://github.com/angelru/CvSlowJittering
While reviewing the above sample, I saw time spent doing culture-aware string "stuff" in Microsoft.Maui.Graphics:
In c40c6e7, I added code analysis rules to the
.editorconfig, but it appears we ignored these warnings in dbaeee9.These are generally easy to fix, we should have just addressed these instead of adding
$(NoWarn).In the future, I will look into adding
CA1311:https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1311
This would find
string.ToLower()calls and recommendstring.ToLowerInvariant()instead. I fixed the one place I saw it affecting performance indotnet-trace.