Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border Margin #7764

Closed
HenJigg opened this issue Jun 5, 2022 · 9 comments · Fixed by #14402
Closed

Border Margin #7764

HenJigg opened this issue Jun 5, 2022 · 9 comments · Fixed by #14402
Assignees
Labels
area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter fixed-in-8.0.0-preview.4.8333 Look for this fix in 8.0.0-preview.4.8333! p/1 Work that is important, and has been scheduled for release in this or an upcoming sprint platform/windows 🪟 t/bug Something isn't working

Comments

@HenJigg
Copy link

HenJigg commented Jun 5, 2022

Description

Border has gaps when no margins are set
1

Steps to Reproduce

MauiApp1.zip

Version with bug

6.0 Release Candidate 3

Last version that worked well

Release Candidate 3 (current)

Affected platforms

Windows

Affected platform versions

Windows 10.0.17763.0

Did you find any workaround?

Manually set a margin of -2

Relevant log output

No response

@HenJigg HenJigg added s/needs-verification Indicates that this issue needs initial verification before further triage will happen t/bug Something isn't working labels Jun 5, 2022
@kristinx0211 kristinx0211 added s/verified Verified / Reproducible Issue ready for Engineering Triage and removed s/needs-verification Indicates that this issue needs initial verification before further triage will happen labels Jun 6, 2022
@kristinx0211
Copy link

verified repro on windows with vs 17.3.0 Preview 3.0 [32605.41.main].
image

@jsuarezruiz jsuarezruiz self-assigned this Jun 6, 2022
@jsuarezruiz jsuarezruiz added area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter labels Jun 6, 2022
@hartez hartez removed their assignment Aug 2, 2022
@Martinedo
Copy link

Actually the workaround is to set Margin="-1" StrokeThickness="0" becuase StrokeThickness = 1 by default.

@shameelfazul
Copy link

is there a fix for this? setting StrokeThickness adds margins even though its set to 0 ..

@jsuarezruiz jsuarezruiz added this to the Backlog milestone Feb 23, 2023
@ghost
Copy link

ghost commented Feb 23, 2023

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@muak
Copy link

muak commented Mar 30, 2023

Why do you put it in Backlog even though there is no workaround and the issue affects migration from Xamarin.Forms?

@hartez
Copy link
Contributor

hartez commented Mar 30, 2023

This may have been fixed by #10964, we need to verify.

@tranb3r
Copy link

tranb3r commented Mar 30, 2023

Could you please verify if #11994 is fixed as well?
Thanks

@rmarinho
Copy link
Member

rmarinho commented Apr 4, 2023

This is still a issue on main, just tested on Android and iOS

<ContentPage
    xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
    xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
    x:Class="Maui.Controls.Sample.MainPage"
    BackgroundColor="yellow">
     <Grid RowDefinitions="*,*" RowSpacing="0" >
        <Rectangle Background="Pink" StrokeThickness="0"  />
        <Rectangle Grid.Row="1" Background="Red" StrokeThickness="0" />
    </Grid>
</ContentPage>

Simulator Screenshot - iPhone 14 Pro Max - 2023-04-04 at 12 07 19
Screenshot_1680606719

@jsuarezruiz jsuarezruiz self-assigned this Apr 4, 2023
@jsuarezruiz jsuarezruiz moved this from Todo to In Progress in MAUI SDK Ongoing Apr 4, 2023
@samhouts samhouts added the p/1 Work that is important, and has been scheduled for release in this or an upcoming sprint label Apr 4, 2023
@jsuarezruiz
Copy link
Contributor

The issue will be fixed by #14402

@samhouts samhouts removed the s/verified Verified / Reproducible Issue ready for Engineering Triage label Apr 5, 2023
rmarinho pushed a commit that referenced this issue Apr 20, 2023
* Fox Border margin issue

* Auto-format source code

---------

Co-authored-by: GitHub Actions Autoformatter <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in MAUI SDK Ongoing Apr 20, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 20, 2023
@samhouts samhouts modified the milestones: Backlog, .NET 8 May 24, 2023
@samhouts samhouts added the fixed-in-8.0.0-preview.4.8333 Look for this fix in 8.0.0-preview.4.8333! label Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter fixed-in-8.0.0-preview.4.8333 Look for this fix in 8.0.0-preview.4.8333! p/1 Work that is important, and has been scheduled for release in this or an upcoming sprint platform/windows 🪟 t/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants