Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border margin issue #11994

Open
tranb3r opened this issue Dec 9, 2022 · 9 comments
Open

Border margin issue #11994

tranb3r opened this issue Dec 9, 2022 · 9 comments
Labels
area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing delighter delighter-sc migration-compatibility Xamarin.Forms to .NET MAUI Migration, Upgrade Assistant, Try-Convert platform/android 🤖 platform/iOS 🍎 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Milestone

Comments

@tranb3r
Copy link

tranb3r commented Dec 9, 2022

Description

I'm trying to use Border in replacement on Frame.
Border and Frame should look the same in this example, but it's not the case.

Here is what it looks like on Android: margin of Border seems wrong.

Here is what it looks like on iOS: thickness of Border seems wrong.

This issue is similar to #7764, however the proposed workaround does not work properly.

Steps to Reproduce

  1. Create a maui app
  2. Add a Border with a Margin
  3. Compare results both on Android and iOS
  4. Compare to a similar design using a Frame

Link to public reproduction project repository

https://github.com/tranb3r/Issues/tree/main/MauiAppBorderMargin

Version with bug

7.0 (current)

Last version that worked well

Unknown/Other

Affected platforms

iOS, Android

Affected platform versions

iOS and Android

Did you find any workaround?

A workaround could consist in adjusting Margin with negative values (on Android).
However, the magical number to set seems to depend on display resolution, so it's not a viable workaround.

Relevant log output

No response

@tranb3r tranb3r added the t/bug Something isn't working label Dec 9, 2022
@jsuarezruiz jsuarezruiz added area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing platform/android 🤖 platform/iOS 🍎 labels Dec 9, 2022
@jsuarezruiz jsuarezruiz self-assigned this Dec 9, 2022
@jsuarezruiz jsuarezruiz added this to the Backlog milestone Dec 9, 2022
@ghost
Copy link

ghost commented Dec 9, 2022

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@tranb3r
Copy link
Author

tranb3r commented Feb 15, 2023

Is this going to be fixed? Or is there any workaround?

@tranb3r tranb3r mentioned this issue Mar 30, 2023
@homeyf
Copy link

homeyf commented Jun 2, 2023

Verified this issue with Visual Studio Enterprise 17.7.0 Preview 1.0. Can repro on android platform with above project.
https://github.com/tranb3r/Issues/tree/main/MauiAppBorderMargin
image

@homeyf homeyf added s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage labels Jun 2, 2023
@tranb3r
Copy link
Author

tranb3r commented Jun 19, 2023

I've tested my repro with net8-pre5, this issue is still here.
Is it going to be fixed in net8?
Thanks

@dotMorten
Copy link
Contributor

dotMorten commented Aug 7, 2023

I'm curious if this is related to #15339 that was just fixed?
If anything it had quite a few border issues on android PRs associated with it.

@tranb3r
Copy link
Author

tranb3r commented Aug 9, 2023

This is what I get on Android with the latest preview (8.0.0-preview.7.8842).

Border Margin seems to have been fixed, but Thickness is still wrong, and RoundRectangle CornerRadius does not seem to work anymore :(

@daltzctr
Copy link
Contributor

Preview 7 seems to have broken thickness on Windows as well. There is clipping on the bottom and right of a border. This is especially noticable on larger thickness values.

@tranb3r
Copy link
Author

tranb3r commented Sep 14, 2023

Any update with RC1 ?

@tranb3r
Copy link
Author

tranb3r commented Sep 22, 2023

With net8-rc.1, most Border issues I was observing previously have been fixed.
However, on Android, there remains a small margin around Border (1px?).
I've updated my repro to demonstrate the issue: the small margin is the red line around Border.

@samhouts samhouts added delighter migration-compatibility Xamarin.Forms to .NET MAUI Migration, Upgrade Assistant, Try-Convert delighter-sc labels Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing delighter delighter-sc migration-compatibility Xamarin.Forms to .NET MAUI Migration, Upgrade Assistant, Try-Convert platform/android 🤖 platform/iOS 🍎 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants