-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[.NET 9] Add a11y fixes to DeveloperBalance App #611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 9 commits
af96f9c
342321f
d54f86f
393cb61
025ef81
3cb6c25
a778431
8651dc6
e45413a
b4712b5
9ef6741
69e30b8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFrameworks>net9.0-android;net9.0-ios;net9.0-maccatalyst</TargetFrameworks> | ||
|
|
@@ -21,17 +21,18 @@ | |
| <Nullable>enable</Nullable> | ||
| <!-- https://github.com/CommunityToolkit/Maui/issues/2205 --> | ||
| <NoWarn>XC0103</NoWarn> | ||
| <MauiVersion>9.0.60</MauiVersion> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we just remove this?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removing it we are going to use 9.1.1 and requires to downgrade the Toolkit, but we use something from the latest versions.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. aw yea :-( Well, we will hopefully be releasing 9.0.81 here soon into workloads |
||
| <MauiEnableXamlCBindingWithSourceCompilation>true</MauiEnableXamlCBindingWithSourceCompilation> | ||
|
|
||
| <!-- Display name --> | ||
| <ApplicationTitle>DeveloperBalance</ApplicationTitle> | ||
|
|
||
| <!-- App Identifier --> | ||
| <ApplicationId>com.companyname.developerbalance</ApplicationId> | ||
| <ApplicationId>com.simplyprofound.balance</ApplicationId> | ||
|
jfversluis marked this conversation as resolved.
Outdated
|
||
|
|
||
| <!-- Versions --> | ||
| <ApplicationDisplayVersion>1.0</ApplicationDisplayVersion> | ||
| <ApplicationVersion>1</ApplicationVersion> | ||
| <ApplicationVersion>2</ApplicationVersion> | ||
|
jsuarezruiz marked this conversation as resolved.
Outdated
|
||
|
|
||
| <!-- To develop, package, and publish an app to the Microsoft Store, see: https://aka.ms/MauiTemplateUnpackaged --> | ||
| <WindowsPackageType>None</WindowsPackageType> | ||
|
|
@@ -63,7 +64,7 @@ | |
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Maui.Controls" Version="9.0.40" /> | ||
| <PackageReference Include="Microsoft.Maui.Controls" Version="$(MauiVersion)" /> | ||
| <PackageReference Include="Microsoft.Extensions.Logging.Debug" Version="9.0.0" /> | ||
| </ItemGroup> | ||
|
|
||
|
|
@@ -72,7 +73,7 @@ | |
| <PackageReference Include="CommunityToolkit.Maui" Version="11.1.1" /> | ||
| <PackageReference Include="Microsoft.Data.Sqlite.Core" Version="8.0.8" /> | ||
| <PackageReference Include="SQLitePCLRaw.bundle_green" Version="2.1.10" /> | ||
| <PackageReference Include="Syncfusion.Maui.Toolkit" Version="1.0.4" /> | ||
| <PackageReference Include="Syncfusion.Maui.Toolkit" Version="1.0.5" /> | ||
| </ItemGroup> | ||
|
|
||
| </Project> | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,4 +6,18 @@ public CategoryChart() | |
| { | ||
| InitializeComponent(); | ||
| } | ||
|
|
||
| protected override void OnHandlerChanged() | ||
| { | ||
| base.OnHandlerChanged(); | ||
|
|
||
| var chart = Chart.Handler?.PlatformView; | ||
|
|
||
| #if WINDOWS | ||
| if (chart is Microsoft.Maui.Platform.ContentPanel contentPanel) | ||
| { | ||
| contentPanel.IsTabStop = true; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we move this to a mapper? Is this an issue that's been highlighted to SF? Should they make this control a tabstop by default?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure, move to a Mapper.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @tj-devel709 Is this an issue that's been highlighted to SF? Should they make this control a tabstop by default? |
||
| } | ||
| #endif | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why only on Android and Windows?