[.NET 9] Add a11y fixes to DeveloperBalance App#611
Merged
Conversation
…ing issues with vscode
jsuarezruiz
requested review from
Copilot,
jfversluis and
tj-devel709
and removed request for
Copilot
There was a problem hiding this comment.
Pull Request Overview
Apply a11y improvements and .NET 9 updates across the DeveloperBalance sample, including replacing legacy layouts with CollectionView, enhancing screen-reader semantics, and refining ViewModel navigation and repository logic.
- Swap ScrollView/BindableLayout for CollectionView and add semantic properties for accessibility
- Introduce null-safe navigation signatures and SelectedProject/SelectedTags properties in page models
- Add Windows-specific tab stops, segment descriptions, and repository association checks
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| nuget.config | New NuGet package source |
| Platforms/MacCatalyst/Info.plist | Added app category key |
| Pages/ProjectListPage.xaml.cs | Bound AppearingBehavior’s context |
| Pages/ProjectListPage.xaml | Swapped to CollectionView and updated semantics |
| Pages/ProjectDetailPage.xaml.cs | Added selection-changed handler |
| Pages/ProjectDetailPage.xaml | Replaced tag templates with multi-select view |
| Pages/MainPage.xaml | Replaced horizontal ScrollView with CollectionView |
| Pages/Controls/TaskView.xaml | Adjusted layout, added automation properties |
| Pages/Controls/ProjectCardView.xaml | Switched to FlexLayout for tags |
| Pages/Controls/CategoryChart.xaml.cs | Enabled tab stop on Windows |
| Pages/Controls/CategoryChart.xaml | Hidden shimmer from accessibility tree |
| PageModels/ProjectListPageModel.cs | Added SelectedProject property, updated command |
| PageModels/ProjectDetailPageModel.cs | Tracked SelectedTags, refactored ToggleTag logic |
| PageModels/MainPageModel.cs | Added SelectedProject, updated navigation command |
| MauiProgram.cs | Appended keyboard focus mapping for Windows |
| DeveloperBalance.csproj | Bumped MauiVersion, package IDs and versions |
| Data/TagRepository.cs | Prevent duplicate tag–project associations |
| AppShell.xaml.cs | Added semantic description for theme selector |
| AppShell.xaml | Added descriptions for light/dark mode segments |
Comments suppressed due to low confidence (4)
PageModels/ProjectListPageModel.cs:31
- The command method signature returns a nullable Task and checks
project is null, butprojectis non-nullable. Change the return type toTask, remove the null check, and callShell.Current.GoToAsync(...)directly.
Task? NavigateToProject(Project project)
PageModels/MainPageModel.cs:155
- This method signature makes the Task nullable and guards against a
nullproject, butprojectis non-nullable. Refactor to returnTask, drop the null check, and callShell.Current.GoToAsync(...)directly.
private Task? NavigateToProject(Project project)
Data/TagRepository.cs:231
- Inside
IsAssociated, callingSaveItemAsync(item)duplicates the initial tag save and incurs extra database overhead. Remove this call and assume the tag exists before checking the association.
await SaveItemAsync(item);
Pages/ProjectDetailPage.xaml:61
- Removing the
SemanticProperties.Hinton the icon grid loses the guidance for screen-reader users. Consider reintroducing a concise hint so that assistive technologies convey actionable context.
SemanticProperties.Hint="Icon representing the type of task . Tap to select"
jsuarezruiz
commented
Jun 13, 2025
| InitializeComponent(); | ||
| var currentTheme = Application.Current!.RequestedTheme; | ||
| ThemeSegmentedControl.SelectedIndex = currentTheme == AppTheme.Light ? 0 : 1; | ||
| #if ANDROID || WINDOWS |
Contributor
Author
There was a problem hiding this comment.
Why only on Android and Windows?
PureWeen
reviewed
Jun 13, 2025
| <Nullable>enable</Nullable> | ||
| <!-- https://github.com/CommunityToolkit/Maui/issues/2205 --> | ||
| <NoWarn>XC0103</NoWarn> | ||
| <MauiVersion>9.0.60</MauiVersion> |
Contributor
Author
There was a problem hiding this comment.
Removing it we are going to use 9.1.1 and requires to downgrade the Toolkit, but we use something from the latest versions.
Member
There was a problem hiding this comment.
aw yea :-(
Well, we will hopefully be releasing 9.0.81 here soon into workloads
PureWeen
reviewed
Jun 13, 2025
| BindingContext = model; | ||
| } | ||
|
|
||
| private async void CollectionView_SelectionChanged(object sender, SelectionChangedEventArgs e) |
Member
There was a problem hiding this comment.
Can this all be moved to a RelayCommand in the ViewModel?
Contributor
Author
There was a problem hiding this comment.
Yes, moved to the ViewModel.
PureWeen
reviewed
Jun 13, 2025
PureWeen
reviewed
Jun 13, 2025
PureWeen
reviewed
Jun 13, 2025
| #if WINDOWS | ||
| if (chart is Microsoft.Maui.Platform.ContentPanel contentPanel) | ||
| { | ||
| contentPanel.IsTabStop = true; |
Member
There was a problem hiding this comment.
Can we move this to a mapper?
Is this an issue that's been highlighted to SF? Should they make this control a tabstop by default?
Contributor
Author
There was a problem hiding this comment.
Sure, move to a Mapper.
Contributor
Author
There was a problem hiding this comment.
@tj-devel709 Is this an issue that's been highlighted to SF? Should they make this control a tabstop by default?
I can follow the conversation with Sf about it.
jfversluis
reviewed
Jun 20, 2025
jfversluis
reviewed
Jun 20, 2025
jfversluis
approved these changes
Jul 1, 2025
9 tasks
Copilot AI
added a commit
that referenced
this pull request
Sep 22, 2025
Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com>
jfversluis
added a commit
that referenced
this pull request
Sep 30, 2025
Apply accessibility fixes from PR #611 to .NET 10 DeveloperBalance app
This was referenced Oct 1, 2025
jfversluis
added a commit
that referenced
this pull request
Oct 10, 2025
Apply missing accessibility fixes from PR #611 to .NET 10 DeveloperBalance app
emperoer
pushed a commit
to emperoer/maui-samples
that referenced
this pull request
Oct 16, 2025
…nce app Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply a11y fixes to DeveloperBalance App to the .NET 9 samples.